Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Makefile: support use of a non-npm version of Hugo #101

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Makefile: support use of a non-npm version of Hugo #101

merged 1 commit into from
Jul 28, 2021

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Jul 27, 2021

Followup to #96

@chalin chalin force-pushed the chalin-make-hugo-var-2021-07-27 branch from 8c9b2bd to 88b3608 Compare July 27, 2021 23:00
nate-double-u
nate-double-u reviewed Jul 27, 2021
View reviewed changes
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to move in the direction of #65, should we go all the way and remove the build/serve from the Makefile completely, and move these functions into the package.json file (like etcd.io?). How is the build/serve being managed with grpc.io?

@chalin
Copy link
Collaborator Author

chalin commented Jul 27, 2021 •
edited
Loading

... should we go all the way and remove the build/serve from the Makefile completely, and move these functions into the package.json ...

Yes, I have that in the works, but I need to resolve one final issue first (related to the use of hugo-extended). Hence this PR, which offers slightly more complete make-target actions, and support for use of a non-npm hugo command.

nate-double-u
nate-double-u approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@chalin chalin merged commit 85dc33a into main Jul 28, 2021
@chalin chalin deleted the chalin-make-hugo-var-2021-07-27 branch July 28, 2021 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nate-double-u nate-double-u nate-double-u approved these changes

@kapunahelewong kapunahelewong Awaiting requested review from kapunahelewong

Assignees
No one assigned
Labels
infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @nate-double-u