test: add proxy cache controller test.

app/core/service/ProxyCacheService.ts

@@ -174,7 +174,7 @@ export class ProxyCacheService extends AbstractService {
     return { proxyBytes, manifest };
   }
 
-  async removeProxyCaches(fullname: string, fileType: DIST_NAMES, version?: string) {
+  async removeProxyCache(fullname: string, fileType: DIST_NAMES, version?: string) {
     const storeKey = isPkgManifest(fileType)
       ? `/${PROXY_MODE_CACHED_PACKAGE_DIR_NAME}/${fullname}/${fileType}`
       : `/${PROXY_MODE_CACHED_PACKAGE_DIR_NAME}/${fullname}/${version}/${fileType}`;

app/port/controller/ProxyCacheController.ts

@@ -10,6 +10,7 @@ import {
   // Context,
   // EggContext,
 } from '@eggjs/tegg';
+import { ForbiddenError, NotFoundError, UnauthorizedError } from 'egg-errors';
 import { AbstractController } from './AbstractController';
 import { ProxyCacheRepository } from '../../repository/ProxyCacheRepository';
 import { Static } from 'egg-typebox-validate/typebox';
@@ -19,6 +20,7 @@ import {
   ProxyCacheService,
   isPkgManifest,
 } from '../../core/service/ProxyCacheService';
+import { SyncMode } from '../../common/constants';
 // import { DIST_NAMES } from '../../../core/entity/Package';
 
 @HTTPController()
@@ -37,6 +39,9 @@ export class ProxyCacheController extends AbstractController {
     @HTTPQuery() pageSize: Static<typeof QueryPageOptions>['pageSize'],
     @HTTPQuery() pageIndex: Static<typeof QueryPageOptions>['pageIndex'],
   ) {
+    if (this.config.cnpmcore.syncMode !== SyncMode.proxy) {
+      throw new ForbiddenError('proxy mode is not enabled');
+    }
     return await this.proxyCacheRepository.listCachedFiles({
       pageSize,
       pageIndex,
@@ -48,17 +53,31 @@ export class ProxyCacheController extends AbstractController {
     path: `/-/proxy-cache/:fullname(${FULLNAME_REG_STRING})`,
   })
   async showProxyCaches(@HTTPParam() fullname: string) {
-    return await this.proxyCacheRepository.findProxyCaches(fullname);
+    if (this.config.cnpmcore.syncMode !== SyncMode.proxy) {
+      throw new ForbiddenError('proxy mode is not enabled');
+    }
+    const result = await this.proxyCacheRepository.findProxyCaches(fullname);
+    if (result.length === 0) {
+      throw new NotFoundError();
+    }
+    return result;
   }
 
   @HTTPMethod({
     method: HTTPMethodEnum.PATCH,
     path: `/-/proxy-cache/:fullname(${FULLNAME_REG_STRING})`,
   })
   async refreshProxyCaches(@HTTPParam() fullname: string) {
+    if (this.config.cnpmcore.syncMode !== SyncMode.proxy) {
+      throw new ForbiddenError('proxy mode is not enabled');
+    }
+
     const refreshList = await this.proxyCacheRepository.findProxyCaches(
       fullname,
     );
+    if (refreshList.length === 0) {
+      throw new NotFoundError();
+    }
     const taskList = refreshList
       // 仅manifests需要更新，指定版本的package.json文件发布后不会改变
       .filter(i => isPkgManifest(i.fileType))
@@ -85,17 +104,21 @@ export class ProxyCacheController extends AbstractController {
   async removeProxyCaches(@Context() ctx: EggContext, @HTTPParam() fullname: string) {
     const isAdmin = await this.userRoleManager.isAdmin(ctx);
     if (!isAdmin) {
-      return {
-        ok: false,
-        error: 'only admin can do this',
-      };
+      throw new UnauthorizedError('only admin can do this');
+    }
+
+    if (this.config.cnpmcore.syncMode !== SyncMode.proxy) {
+      throw new ForbiddenError('proxy mode is not enabled');
     }
 
     const proxyCachesList = await this.proxyCacheRepository.findProxyCaches(
       fullname,
     );
+    if (proxyCachesList.length === 0) {
+      throw new NotFoundError();
+    }
     const removingList = proxyCachesList.map(item => {
-      return this.proxyCacheService.removeProxyCaches(item.fullname, item.fileType, item.version);
+      return this.proxyCacheService.removeProxyCache(item.fullname, item.fileType, item.version);
     });
     await Promise.all(removingList);
     return {
@@ -111,10 +134,11 @@ export class ProxyCacheController extends AbstractController {
   async truncateProxyCaches(@Context() ctx: EggContext) {
     const isAdmin = await this.userRoleManager.isAdmin(ctx);
     if (!isAdmin) {
-      return {
-        ok: false,
-        error: 'only admin can do this',
-      };
+      throw new UnauthorizedError('only admin can do this');
+    }
+
+    if (this.config.cnpmcore.syncMode !== SyncMode.proxy) {
+      throw new ForbiddenError('proxy mode is not enabled');
     }
 
     // 需要手动清除对象存储上的缓存