-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: revalidate latest version #573
Conversation
Codecov Report
@@ Coverage Diff @@
## master #573 +/- ##
==========================================
- Coverage 97.02% 96.99% -0.04%
==========================================
Files 174 175 +1
Lines 16588 16774 +186
Branches 2177 2202 +25
==========================================
+ Hits 16095 16270 +175
- Misses 493 504 +11
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@@ -262,9 +269,23 @@ export class BinarySyncerService extends AbstractService { | |||
existsItem.sourceUrl = item.url; | |||
existsItem.ignoreDownloadStatuses = item.ignoreDownloadStatuses; | |||
existsItem.date = item.date; | |||
} else if (dir.endsWith(latestVersionParent)) { | |||
const isLatestItem = sortBy(fetchItems, [ 'date' ]).pop()?.name === item.name; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#698 这里有性能问题
diff
method, adding latest version check method.diff
方法,添加最新版本校验逻辑