Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use tar fork version to fix memory leak #625

Merged
merged 1 commit into from
Dec 18, 2023
Merged

fix: use tar fork version to fix memory leak #625

merged 1 commit into from
Dec 18, 2023

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Dec 18, 2023

closes #624

@fengmk2 fengmk2 requested review from elrrrrrrr and killagu December 18, 2023 02:55
@fengmk2
Copy link
Member Author

fengmk2 commented Dec 18, 2023

先 fork 一个版本临时修复一下。
fengmk2/node-tar@710e2be

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 167 lines in your changes are missing coverage. Please review.

Comparison is base (6624a36) 97.45% compared to head (39028f2) 96.83%.
Report is 145 commits behind head on master.

Files Patch % Lines
config/config.default.ts 53.03% 31 Missing ⚠️
.../port/controller/admin/PaddingVersionController.ts 48.83% 22 Missing ⚠️
app/core/service/FixNoPaddingVersionService.ts 54.54% 15 Missing ⚠️
app/core/service/PackageSearchService.ts 93.64% 15 Missing ⚠️
app/core/service/PackageSyncerService.ts 85.84% 15 Missing ⚠️
app/port/schedule/SyncBinaryWorker.ts 21.42% 11 Missing ⚠️
app/repository/PackageVersionRepository.ts 87.95% 10 Missing ⚠️
app/core/service/PackageVersionFileService.ts 91.57% 8 Missing ⚠️
app/core/entity/PaddingSemVer.ts 88.00% 6 Missing ⚠️
app/core/service/PackageVersionService.ts 94.91% 6 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
- Coverage   97.45%   96.83%   -0.62%     
==========================================
  Files         168      180      +12     
  Lines       15691    17548    +1857     
  Branches     2018     2285     +267     
==========================================
+ Hits        15291    16993    +1702     
- Misses        400      555     +155     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengmk2 fengmk2 merged commit 6c519f7 into master Dec 18, 2023
10 of 12 checks passed
@fengmk2 fengmk2 deleted the tmp-fix-tar branch December 18, 2023 03:03
fengmk2 pushed a commit that referenced this pull request Dec 18, 2023
[skip ci]

## [3.49.1](v3.49.0...v3.49.1) (2023-12-18)

### Bug Fixes

* use tar fork version to fix memory leak ([#625](#625)) ([6c519f7](6c519f7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cacheKeyNormalize 存在性能问题
1 participant