-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mirror edgewebdriver #676
Conversation
WalkthroughThis update introduces the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- app/common/adapter/binary/EdgedriverBinary.ts (1 hunks)
- app/common/enum/Binary.ts (1 hunks)
- config/binaries.ts (1 hunks)
- test/common/adapter/binary/EdgedriverBinary.test.ts (1 hunks)
- test/fixtures/edgeupdates.json (1 hunks)
Files skipped from review due to trivial changes (2)
- config/binaries.ts
- test/fixtures/edgeupdates.json
Additional comments not posted (3)
app/common/enum/Binary.ts (1)
16-16
: Addition ofEdgedriver
toBinaryType
enum is appropriate for supporting new binary types.test/common/adapter/binary/EdgedriverBinary.test.ts (1)
6-76
: Comprehensive test setup and method forEdgedriverBinary.fetch
. Ensures proper functionality and error handling.app/common/adapter/binary/EdgedriverBinary.ts (1)
8-213
: Well-structuredEdgedriverBinary
class with appropriate methods for handling Edge WebDriver binaries. Good use of decorators and error handling.
[skip ci] ## [3.56.0](v3.55.1...v3.56.0) (2024-05-11) ### Features * mirror edgewebdriver ([#676](#676)) ([21cbc18](21cbc18))
closes #594
Summary by CodeRabbit
New Features
Documentation
Tests