Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mirror edgewebdriver #676

Merged
merged 1 commit into from
May 11, 2024
Merged

feat: mirror edgewebdriver #676

merged 1 commit into from
May 11, 2024

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented May 11, 2024

closes #594

Summary by CodeRabbit

  • New Features

    • Introduced the EdgedriverBinary class to enhance the fetching and management of Edgedriver binaries.
    • Added support for the Edgedriver type in our binary management system.
    • Updated the binaries configuration to include the new Edgedriver category, complete with repository and distribution details.
  • Documentation

    • Updated documentation to reflect the addition of the Edgedriver category and its functionalities.
  • Tests

    • Implemented new tests for the EdgedriverBinary class to ensure functionality works as expected.

@fengmk2 fengmk2 added the enhancement New feature or request label May 11, 2024
Copy link
Contributor

coderabbitai bot commented May 11, 2024

Walkthrough

This update introduces the EdgedriverBinary class to manage EdgeDriver binary synchronization, including fetching and parsing binary data. The changes also include the addition of EdgeDriver as a binary type and its configuration settings, as well as the necessary testing infrastructure to ensure functionality.

Changes

File Path Change Summary
.../adapter/binary/EdgedriverBinary.ts Added EdgedriverBinary class with methods for fetching and parsing EdgeDriver binaries.
.../enum/Binary.ts Added Edgedriver to BinaryType enum.
config/binaries.ts Added configuration for edgedriver including URLs and descriptions.
.../binary/EdgedriverBinary.test.ts Introduced tests for the new EdgedriverBinary functionalities.
test/fixtures/edgeupdates.json Added test fixture data for EdgeDriver updates across various platforms.

Assessment against linked issues

Objective Addressed Explanation
Sync EdgeDriver binaries including latest release (#594)

Poem

🐇 Oh hoppity hop, the code does leap,
Across the fields where binaries sleep.
🌟 New paths we pave, with Edge in sight,
Syncing drivers through the night.
🎉 Celebrate this code, so bright and new,
A rabbit's touch, made just for you!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fengmk2 fengmk2 marked this pull request as draft May 11, 2024 10:06
@fengmk2 fengmk2 marked this pull request as ready for review May 11, 2024 10:08
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 67f1a24 and 036a6f4.
Files selected for processing (5)
  • app/common/adapter/binary/EdgedriverBinary.ts (1 hunks)
  • app/common/enum/Binary.ts (1 hunks)
  • config/binaries.ts (1 hunks)
  • test/common/adapter/binary/EdgedriverBinary.test.ts (1 hunks)
  • test/fixtures/edgeupdates.json (1 hunks)
Files skipped from review due to trivial changes (2)
  • config/binaries.ts
  • test/fixtures/edgeupdates.json
Additional comments not posted (3)
app/common/enum/Binary.ts (1)

16-16: Addition of Edgedriver to BinaryType enum is appropriate for supporting new binary types.

test/common/adapter/binary/EdgedriverBinary.test.ts (1)

6-76: Comprehensive test setup and method for EdgedriverBinary.fetch. Ensures proper functionality and error handling.

app/common/adapter/binary/EdgedriverBinary.ts (1)

8-213: Well-structured EdgedriverBinary class with appropriate methods for handling Edge WebDriver binaries. Good use of decorators and error handling.

@fengmk2 fengmk2 merged commit 21cbc18 into master May 11, 2024
11 checks passed
@fengmk2 fengmk2 deleted the mirror-edgedriver branch May 11, 2024 10:09
fengmk2 pushed a commit that referenced this pull request May 11, 2024
[skip ci]

## [3.56.0](v3.55.1...v3.56.0) (2024-05-11)

### Features

* mirror edgewebdriver ([#676](#676)) ([21cbc18](21cbc18))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【扩展请求】是否有计划将edgedriver列入同步列表中?
1 participant