-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
dev: add extra startup flag to fix breakage on Darwin/ARM64 machines
When cross-building, Java can crash on Darwin/ARM64 machines due to an error that looks like this: ``` A fatal error has been detected by the Java Runtime Environment: SIGILL (0x4) at pc=0x0000ffffadf3fc1c, pid=39, tid=40 ``` This was addressed in #139670, which adds a startup flag to disable the use of SVE. Unfortunately this broke the build on x86-64 machines (#139756). So now we must apply the flag conditionally only where relevant. Closes: #139756 Epic: none Release note: None
- Loading branch information
1 parent
5bcfd2a
commit 56a07da
Showing
4 changed files
with
16 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
# As of late 2024/early 2025, current versions of java crash when run in a guest | ||
# VM on a MacOS 15.2 host running on an M4 chip. Disbaling SVE avoids this | ||
# crash until patched versions of Java become available. | ||
|
||
# NB: We mount this into the Docker container when building on macOS ARM64 host | ||
# machines specifically. Other machines get empty.bazelrc. | ||
startup --host_jvm_args="-XX:UseSVE=0" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1 @@ | ||
# This file is mounted as .bazelrc.user for cross builds and must exist, so | ||
# keep it here (even if it becomes empty). | ||
|
||
# As of late 2024/early 2025, current versions of java crash when run in a guest | ||
# VM on a MacOS 15.2 host running on an M4 chip. Disbaling SVE avoids this | ||
# crash until patched versions of Java become available. | ||
startup --host_jvm_args="-XX:UseSVE=0" | ||
# intentionally empty (this file is mounted as .bazelrc.user for cross builds) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters