storage: remove SingleDel invariant cluster settings #138541
Conversation
Changes: * [`d21c9e72`](cockroachdb/pebble@d21c9e72) db: add PossibleAPIMisuseEvent * [`e2d1b6cf`](cockroachdb/pebble@e2d1b6cf) cockroachkvs: add FormatKey, ParseFormattedKey Release note: none. Epic: none.
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
There was a problem hiding this comment.
Thought of another instance where we could use this new misuse API event and filed cockroachdb/pebble#4234
Reviewed 4 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @sumeerbhola)
There was a problem hiding this comment.
TFTR! Good idea!
Reviewable status:
There was a problem hiding this comment.
bors r+
Reviewable status:
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
pkg/storage/pebble.go line 1547 at r2 (raw file):
log.Infof(p.logCtx, "possible ineffectual SingleDel on key %s", roachpb.Key(info.UserKey)) } atomic.AddInt64(&p.singleDelInvariantViolationCount, 1)
shouldn't this increment p.singleDelIneffectualCount, in that the increments here and below have been swapped.
|
bors r- |
Also refactor SingleDel invariant callbacks to use the new event. Epic: none Release note: None
RaduBerinde
force-pushed
the
api-misuse
branch
from
17b454e to
443ecee
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/storage/pebble.go line 1547 at r2 (raw file):
Previously, sumeerbhola wrote…
shouldn't this increment
p.singleDelIneffectualCount, in that the increments here and below have been swapped.
Good catch, fixed. Thanks!!
There was a problem hiding this comment.
Reviewable status:
|
bors r+ |
go.mod: bump Pebble to d21c9e72493f
Changes:
d21c9e72db: add PossibleAPIMisuseEvente2d1b6cfcockroachkvs: add FormatKey, ParseFormattedKeyRelease note: none.
Epic: none.
storage: remove SingleDel invariant cluster settings
Also refactor SingleDel invariant callbacks to use the new event.
Epic: none
Release note: None