Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: changefeedccl: migrate pts records to include new tables #138668

Open
wants to merge 1 commit into
base: release-24.1
Choose a base branch
from

Conversation

asg0451
Copy link
Contributor

@asg0451 asg0451 commented Jan 8, 2025

Backport 1/1 commits from #137548.

/cc @cockroachdb/release

Release justification: allow existing feeds to leverage newly added system table pts entries, bug fix


Update the pts records of running feeds when the
set of targets changes, such as when we add new
system tables to protect.

Fixes: #133578
Part of: #128806

Release note (general change): The pts records of
running feeds are now updated when the set of
targets changes, such as when system tables
are added to the protected tables list.

@asg0451 asg0451 requested a review from a team as a code owner January 8, 2025 19:41
@asg0451 asg0451 requested review from wenyihu6 and removed request for a team January 8, 2025 19:41
Copy link

blathers-crl bot commented Jan 8, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jan 8, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Update the pts records of running feeds when the
set of targets changes, such as when we add new
system tables to protect.

Fixes: cockroachdb#133578
Part of: cockroachdb#128806

Release note (general change): The pts records of
running feeds are now updated when the set of
targets changes, such as when system tables
are added to the protected tables list.
@asg0451 asg0451 force-pushed the backport24.1-137548 branch from b1d5cbf to 57b46ab Compare January 9, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants