backup: remove bulkio.backup.elide_common_prefix.enabled setting #138674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
msbutler
requested review from
dt and
jeffswenson
and removed request for
a team
|
I think we are supposed to add deleted settings to the |
RaduBerinde
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
retiredSettings
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @dt and @jeffswenson)
msbutler
force-pushed
the
butler-remove-elision-setting
branch
from
8d0909c to
5f6ed50
Compare
This private setting was introduced in 24.1 and was default true to provide more flexibility around whether backup keys should contain prefixes. After a few releases, we have baked prefixless backups sufficiently, so we can remove the setting. Epic: none Release note: none
msbutler
force-pushed
the
butler-remove-elision-setting
branch
from
5f6ed50 to
94d0a78
Compare
RaduBerinde
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Reviewable status:
|
TFTR! bors r=raduberinde |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This private setting was introduced in 24.1 and was default true to provide more flexibility around whether backup keys should contain prefixes. After a few releases, we have baked prefixless backups sufficiently, so we can remove the setting.
Epic: none
Release note: none