crosscluster: introduce ClusterUri and ConfigUri #138689
Open
+646
−506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the streamclient interface by removing the Dial method and moving the validation in Dial to interface construction time. Release note: none Epic: CRDB-40896
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. It looks like your PR touches SQL parser code but doesn't add or edit parser tests. Please make sure you add or edit parser tests if you edit the parser. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
|
This PR depends on #138092 |
dt
approved these changes
Jan 9, 2025
This change introduces two types to replace StreamAddress. ConfigUri is the URI supplied by the user to the job. ConfigUri may be an external connection. ClusterUri is the Uri used to dial nodes in the destination cluster. This split was made to support the LDR/PCR over load balancer changes. The routing mode is defined by a URI parameter and the external connection needs to be resolved before the routing mode can be determined. The types allow us to add routing mode as ClusterUri method. There is one non-cosmetic change in this PR. The PCR job now tries to use the config URI as the first URI to connect to even if it checkpointed URIs for individual nodes (see stream_ingestion_job.go). This matches the behavior of LDR and is needed to properly handle updates to external URIs. Release Note: none Epic: CRDB-40896
jeffswenson
force-pushed
the
jeffswenson-crosscluster-refactoring
branch
from
87f4a66 to
d939b57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces two types to replace StreamAddress. ConfigUri is
the URI supplied by the user to the job. ConfigUri may be an external
connection. ClusterUri is the Uri used to dial nodes in the destination
cluster.
This split was made to support the LDR/PCR over load balancer changes.
The routing mode is defined by a URI parameter and the external
connection needs to be resolved before the routing mode can be
determined. The types allow us to add routing mode as ClusterUri method.
There is one non-cosmetic change in this PR. The PCR job now tries to
use the config URI as the first URI to connect to even if it
checkpointed URIs for individual nodes (see stream_ingestion_job.go).
This matches the behavior of LDR and is needed to properly handle
updates to external URIs.
Release Note: none
Epic: CRDB-40896