Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-24.1: tree: fix parsing of arrays of spatial types #138693

Open
wants to merge 1 commit into
base: release-24.1
Choose a base branch
from
Open

release-24.1: tree: fix parsing of arrays of spatial types #138693

wants to merge 1 commit into from

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jan 8, 2025

Backport 1/1 commits from #138557 on behalf of @rafiss.

/cc @cockroachdb/release

Arrays with spatial types are different than other arrays -- they always use : as a delimiter instead of ,.

fixes #138140
Release note (bug fix): Queries that perform a cast from the string representation of an array containing geometry or geography types to a SQL array type will now succeed.

Release justification:

@rafiss
tree: fix parsing of arrays of spatial types
fef7e6c 
Arrays with spatial types are different than other arrays -- they always
use ':' as a delimiter instead of ','.

Release note (bug fix): Queries that perform a cast from the string
representation of an array containing geometry or geography types to a
SQL array type will now succeed.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-138557 branch from 76eff78 to fef7e6c Compare January 8, 2025 23:08
@blathers-crl blathers-crl bot requested a review from a team as a code owner January 8, 2025 23:08
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jan 8, 2025
@blathers-crl blathers-crl bot requested a review from Dedej-Bergin January 8, 2025 23:08
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Jan 8, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jan 8, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dedej-Bergin Dedej-Bergin Awaiting requested review from Dedej-Bergin

At least 1 approving review is required to merge this pull request.

Assignees

@rafiss rafiss

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cockroach-teamcity @rafiss