release,build: don't imply lintonbuild in ci configuration
#138698
+243
−239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickystewart
added
the
backport-24.3.x
|
This change is |
rickystewart
force-pushed
the
ci-no-imply-validations
branch
from
f3ce97b to
54e4a27
Compare
The `ci` configuration is overloaded and is used for a few different things. It is used in builds to enable `lintonbuild`, and it's used in tests to set some configurations that are useful in TeamCity (increased verbosity, etc.) While running lints every time we build in a paranoid, repetitive fashion does mean that lint issues cannot go unnoticed, it does have a performance impact (see cockroachdb#136626). Going forward, we will not have this configuration imply `lintonbuild` and provide the option to disable `nogo` for certain builds in automation. For example, `roachtest`s will benefit from having lints disabled as well to speed up the build. Here, we do the following: 1. Have `--config=ci` not imply enabling lints 2. Now, `--config=ci` has no specific meaning for builds (it's only meaningful for tests). So, I go through all the scripts and automation and remove it for builds specifically. 3. Disable `nogo` for release builds to reduce the likelihood of an OOM. Part of: cockroachdb#136626 Epic: CRDB-41952 Release note: None
rickystewart
force-pushed
the
ci-no-imply-validations
branch
from
54e4a27 to
2f9e00f
Compare
This was referenced Jan 8, 2025
rail
approved these changes
Jan 9, 2025
|
bors r=rail |
craig bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
138698: release,build: don't imply `lintonbuild` in `ci` configuration r=rail a=rickystewart The `ci` configuration is overloaded and is used for a few different things. It is used in builds to enable `lintonbuild`, and it's used in tests to set some configurations that are useful in TeamCity (increased verbosity, etc.) While running lints every time we build in a paranoid, repetitive fashion does mean that lint issues cannot go unnoticed, it does have a performance impact (see #136626). Going forward, we will not have this configuration imply `lintonbuild` and provide the option to disable `nogo` for certain builds in automation. For example, `roachtest`s will benefit from having lints disabled as well to speed up the build. Here, we do the following: 1. Have `--config=ci` not imply enabling lints 2. Now, `--config=ci` has no specific meaning for builds (it's only meaningful for tests). So, I go through all the scripts and automation and remove it for builds specifically. 3. Disable `nogo` for release builds to reduce the likelihood of an OOM. Part of: #136626 Epic: CRDB-41952 Release note: None 138700: release: enable PGO on releases r=rail a=rickystewart Part of: CRDB-44692 Epic: CRDB-41952 Release note: Build CRDB binary with PGO enabled 138702: roachtest: when building, don't run `nogo` r=rail a=rickystewart Part of: #136626 Epic: None Release note: None 138703: roachtest: build artifacts with PGO r=rail a=rickystewart Epic: CRDB-41952 Release note: None Co-authored-by: Ricky Stewart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ciconfiguration is overloaded and is used for a few different things. It is used in builds to enablelintonbuild, and it's used in tests to set some configurations that are useful in TeamCity (increased verbosity, etc.)While running lints every time we build in a paranoid, repetitive fashion does mean that lint issues cannot go unnoticed, it does have a performance impact (see #136626). Going forward, we will not have this configuration imply
lintonbuildand provide the option to disablenogofor certain builds in automation. For example,roachtests will benefit from having lints disabled as well to speed up the build.Here, we do the following:
--config=cinot imply enabling lints--config=cihas no specific meaning for builds (it's only meaningful for tests). So, I go through all the scripts and automation and remove it for builds specifically.nogofor release builds to reduce the likelihood of an OOM.Part of: #136626
Epic: CRDB-41952
Release note: None