admission: incorporate higher compaction rate during WAL failover #138708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
sumeerbhola
commented
Jan 9, 2025
There was a problem hiding this comment.
First commit is from #138699
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @aadityasondhi)
aadityasondhi
approved these changes
Jan 9, 2025
sumeerbhola
force-pushed
the
ac_wal_failover
branch
from
5aa052a to
5466228
Compare
|
TFTR! |
|
|
|
bors r=aadityasondhi |
craig bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
138708: admission: incorporate higher compaction rate during WAL failover r=aadityasondhi a=sumeerbhola WAL failover can happen even when the throughput sustainable by the primary is high (since we tune WAL failover to happen at a 100ms latency threshold). So if the workload increase is resulting in more compactions, we should incorporate that into the tokens given out by the ioLoadListener. Informs #138655 Epic: none Release note: None Co-authored-by: sumeerbhola <[email protected]>
|
Build failed: |
WAL failover can happen even when the throughput sustainable by the primary is high (since we tune WAL failover to happen at a 100ms latency threshold). So if the workload increase is resulting in more compactions, we should incorporate that into the tokens given out by the ioLoadListener. Informs cockroachdb#138655 Epic: none Release note: None
sumeerbhola
force-pushed
the
ac_wal_failover
branch
from
5466228 to
e423f3e
Compare
|
bors r=aadityasondhi |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WAL failover can happen even when the throughput sustainable by the primary
is high (since we tune WAL failover to happen at a 100ms latency threshold).
So if the workload increase is resulting in more compactions, we should
incorporate that into the tokens given out by the ioLoadListener.
Informs #138655
Epic: none
Release note: None