idxtype: add idxtype package #139786
Open
idxtype: add idxtype package #139786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new sql/sem/idxtype package that defines an index type enum with values like forward, inverted, and vector. Code across SQL needs to check the index type and previously it used multiple different enums and bools. This commit continues the process of unifying these mechanisms (future commits will do even more). Epic: CRDB-42943 Release note: None
Now that we have the new idxtype.T enumeration that specifies the type of index (e.g. forward, inverted, vector), use that in the opt packages rather than IsInverted and IsVector boolean functions. This will make our code more extensible, such that adding new index types is easier, starting with vector indexes. Epic: CRDB-42943 Release note: None
andy-kimball
requested review from
jeffswenson
and removed request for
a team
|
This change is |
|
Note that there are 3 commits in this PR: the 1st commit contains mostly Foundations changes and the 2nd commit mostly Queries changes. The 3rd commit adds |
Add helper functions that specify the capabilities of various index types. For example, only FORWARD indexes can be primary or unique, and only INVERTED and VECTOR indexes support prefix columns. Use these new helper functions across the SQL packages. Epic: CRDB-42943 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new sql/sem/idxtype package that defines an index type enum with values
like forward, inverted, and vector, as well as "capability" functions describing
what the index can or cannot do. Code across SQL needs to check the index
type and previously it used multiple different enums and bools. This commit
continues the process of unifying these mechanisms (future commits will do
even more).
Epic: CRDB-42943
Release note: None