bazel: stage all go source files in a temp dir named after the package #65094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
cc @knz |
knz
approved these changes
May 13, 2021
There was a problem hiding this comment.
Ooooh shiny ✨
I went to look at your change in rules_go: cockroachdb/rules_go@a94a425
this looks reasonable to me.
I think this change is generally beneficial even though it doesn't fix the failing test right away. Thank you a lot for looking into it.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @rail)
rail
approved these changes
May 13, 2021
There was a problem hiding this comment.
Reviewable status:
|
One broken unit test, let me take care of that really quick... |
This works around an issue where Go source file names as stored in the `cockroach` binary were truncated (e.g., with the leading `github.com/cockroachdb/cockroach` prefix, or even the entire package name prefix, removed). This breaks unit tests (cockroachdb#61913) and some other internal stuff. We solve this by staging all Go source files during the build in a temporary directory named after the package. This incurs an additional I/O cost, but for now while our codebase isn't able to deal with the differing file names, we can deal with it. Fixes cockroachdb#64379 See also cockroachdb#64383 Release note: None
rickystewart
force-pushed
the
go_filenames
branch
from
414e861 to
1b78c30
Compare
|
bors r=rail,knz |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around an issue where Go source file names as stored in the
cockroachbinary were truncated (e.g., with the leadinggithub.com/cockroachdb/cockroachprefix, or even the entire packagename prefix, removed). This breaks unit tests (#61913) and some other
internal stuff.
We solve this by staging all Go source files during the build in a
temporary directory named after the package. This incurs an additional
I/O cost, but for now while our codebase isn't able to deal with the
differing file names, we can deal with it.
Fixes #64379
See also #64383
Release note: None