stopper: Add method for task-tracking #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobvawter
added a commit
to cockroachdb/replicator
that referenced
this pull request
Aug 29, 2024
This change corrects a context-break, where callbacks executed by the key scheduler were executed using a context from the scheduler's workgroup. In cases where the lease loop recycles and the target database is executing slowly, the old queries were not guaranteed to have been canceled when the next iteration of the loop starts. This commit depends on cockroachdb/field-eng-powertools#4
This change adds a Call() method to stopper.Context. This allows the stopper to track tasks that were not started using the Go() method. Additionally, a Len() method is added to return the number of tasks being tracked within a stopper hierarchy.
bobvawter
force-pushed
the
bob_stopper_call
branch
from
0bbf638 to
b99e99b
Compare
sravotto
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @BramGruneir and @MattWhelan)
BramGruneir
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:
bobvawter
added a commit
to cockroachdb/replicator
that referenced
this pull request
Aug 29, 2024
This change corrects a context-break, where callbacks executed by the key scheduler were executed using a context from the scheduler's workgroup. In cases where the lease loop recycles and the target database is executing slowly, the old queries were not guaranteed to have been canceled when the next iteration of the loop starts. This commit depends on cockroachdb/field-eng-powertools#4
bobvawter
added a commit
to cockroachdb/replicator
that referenced
this pull request
Aug 29, 2024
This change corrects a context-break, where callbacks executed by the key scheduler were executed using a context from the scheduler's workgroup. In cases where the lease loop recycles and the target database is executing slowly, the old queries were not guaranteed to have been canceled when the next iteration of the loop starts. Replicator will now exit if a stuck task is detected by the lease loop since there is no other way to guarantee that the task would not continue at some arbitrary point in the future. This commit depends on cockroachdb/field-eng-powertools#4
github-merge-queue bot
pushed a commit
to cockroachdb/replicator
that referenced
this pull request
Aug 29, 2024
This change corrects a context-break, where callbacks executed by the key scheduler were executed using a context from the scheduler's workgroup. In cases where the lease loop recycles and the target database is executing slowly, the old queries were not guaranteed to have been canceled when the next iteration of the loop starts. Replicator will now exit if a stuck task is detected by the lease loop since there is no other way to guarantee that the task would not continue at some arbitrary point in the future. This commit depends on cockroachdb/field-eng-powertools#4
bobvawter
added a commit
to cockroachdb/replicator
that referenced
this pull request
Aug 29, 2024
This change corrects a context-break, where callbacks executed by the key scheduler were executed using a context from the scheduler's workgroup. In cases where the lease loop recycles and the target database is executing slowly, the old queries were not guaranteed to have been canceled when the next iteration of the loop starts. Replicator will now exit if a stuck task is detected by the lease loop since there is no other way to guarantee that the task would not continue at some arbitrary point in the future. This commit depends on cockroachdb/field-eng-powertools#4 (cherry picked from commit 644ad7c)
bobvawter
added a commit
to cockroachdb/replicator
that referenced
this pull request
Aug 29, 2024
This change corrects a context-break, where callbacks executed by the key scheduler were executed using a context from the scheduler's workgroup. In cases where the lease loop recycles and the target database is executing slowly, the old queries were not guaranteed to have been canceled when the next iteration of the loop starts. Replicator will now exit if a stuck task is detected by the lease loop since there is no other way to guarantee that the task would not continue at some arbitrary point in the future. This commit depends on cockroachdb/field-eng-powertools#4 (cherry picked from commit 644ad7c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a Call() method to stopper.Context. This allows the stopper to track tasks that were not started using the Go() method.
Additionally, a Len() method is added to return the number of tasks being tracked within a stopper hierarchy.
This change is