Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemawatch: Refresh Watch method to return a notify.Var #952

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

bobvawter
Copy link
Contributor

@bobvawter bobvawter commented Aug 9, 2024

This change updates the Watcher.Watch() method to return a notify.Var to make it consistent with other sources of asynchronous updates. This will make a follow-on change to cache the target's schema cleaner to implement.

X-Ref: #902


This change is Reviewable

@bobvawter bobvawter marked this pull request as ready for review August 9, 2024 22:51
Copy link
Member

@BramGruneir BramGruneir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @bobvawter and @sravotto)


internal/target/schemawatch/watcher.go line 89 at r1 (raw file):

// Get implements types.Watcher.
func (w *watcher) Get() *types.SchemaData {
	ret, _ := w.data.Get()

please add comments as to why the return values are not needed

This change updates the Watcher.Watch() method to return a notify.Var to make
it consistent with other sources of asynchronous updates. This will make a
follow-on change to cache the target's schema cleaner to implement.

X-Ref: #902
@bobvawter bobvawter enabled auto-merge August 13, 2024 13:27
@bobvawter bobvawter added this pull request to the merge queue Aug 13, 2024
Merged via the queue into master with commit adc67ac Aug 13, 2024
51 of 52 checks passed
@bobvawter bobvawter deleted the cache_schema_info branch August 13, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants