Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group renderers-js e2e dependencies #413

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

lorisleiva
Copy link
Member

@lorisleiva lorisleiva commented Jan 27, 2025

Use a nested pnpm workspace in order to maintain all e2e dependencies in a single package.json.

Copy link

changeset-bot bot commented Jan 27, 2025

⚠️ No Changeset found

Latest commit: 84eb30d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lorisleiva lorisleiva mentioned this pull request Jan 27, 2025
Copy link
Member Author

lorisleiva commented Jan 27, 2025

@lorisleiva lorisleiva marked this pull request as ready for review January 27, 2025 15:54
@lorisleiva lorisleiva force-pushed the 01-27-remove_redundant_pnpm_workspace_info branch from b7f2e8e to ea47570 Compare January 27, 2025 15:57
@lorisleiva lorisleiva force-pushed the 01-27-group_renderers-js_e2e_dependencies branch from 0a5969b to da67790 Compare January 27, 2025 15:57
febo
febo previously approved these changes Jan 27, 2025
Copy link
Member Author

lorisleiva commented Jan 27, 2025

Merge activity

@lorisleiva lorisleiva changed the base branch from 01-27-remove_redundant_pnpm_workspace_info to graphite-base/413 January 27, 2025 16:48
@lorisleiva lorisleiva force-pushed the 01-27-group_renderers-js_e2e_dependencies branch from da67790 to b9f1d83 Compare January 27, 2025 17:00
@lorisleiva lorisleiva force-pushed the 01-27-group_renderers-js_e2e_dependencies branch from b9f1d83 to 84eb30d Compare January 27, 2025 17:02
@lorisleiva lorisleiva changed the base branch from graphite-base/413 to main January 27, 2025 17:02
@lorisleiva lorisleiva dismissed febo’s stale review January 27, 2025 17:02

The base branch was changed.

@lorisleiva lorisleiva merged commit 1f9c445 into main Jan 27, 2025
9 checks passed
@lorisleiva lorisleiva deleted the 01-27-group_renderers-js_e2e_dependencies branch January 27, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants