Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix actions with on* (eg onBlur) #55

Open
josemarluedke opened this issue Aug 1, 2019 · 4 comments
Open

Prefix actions with on* (eg onBlur) #55

josemarluedke opened this issue Aug 1, 2019 · 4 comments

Comments

@josemarluedke
Copy link
Contributor

It would be more idiomatic if the actions would be all prefixed with on*. For example: onBlur onChange, onComplete etc.

It is also confusing because of ember's component events names in the component class: https://guides.emberjs.com/release/components/handling-events/#toc_event-names

@lindyhopchris
Copy link
Contributor

+1 on this. I think however it makes sense to cut a release with where we're at now (think that will be 0.5), then make this change for the release after that?

@josemarluedke
Copy link
Contributor Author

After #47 is merged, I can get a PR for this by adding a deprecation for the old way while keeping it working. You can release a version that has the deprecation, then we can remove that in a followup version.

@lindyhopchris
Copy link
Contributor

Sounds like a plan :-)

@lindyhopchris
Copy link
Contributor

@josemarluedke think we could probably do with a PR on this as it's starting to cause confusion (understandably!). Would you have time to do that at some point (not asking for it immediately, just wondering if you still have time in theory!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants