Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay lobby #119

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Replay lobby #119

wants to merge 23 commits into from

Conversation

SiimonStark
Copy link
Contributor

@SiimonStark SiimonStark commented Aug 13, 2019

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

When game ends:

  • If user clicks "New Game" => they will be linked to the StartScreen with a cleared Game State
  • If user clicks "Play Again" => they will be linked to the Lobby with their name and new InviteCode persisting.
    I ran several playthroughs to confirm this feature works as intended.
    ** Note: for the server, I pulled down an "in-progress" branch

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other, Please explain:
    Your message here

Has This Been Tested?

  • No
  • Yes
    Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration:
    Your message here
  • Have any prior tests been changed?
    If so, please explain:
    Your message here

Additional notes:

Your message here

Checklist:

  • My code has no unused/commented out code
  • My code has no console logs
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas

Co-Authored-By: Justin Pyktel [email protected]

@SiimonStark SiimonStark added good first issue Good for newcomers Extention Front-End Frontend facing project label labels Aug 13, 2019
@SiimonStark SiimonStark added this to the Extensions milestone Aug 13, 2019
@SiimonStark SiimonStark requested a review from lynnerang August 13, 2019 07:29
@SiimonStark SiimonStark self-assigned this Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extention Front-End Frontend facing project label good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants