246 code cleanup #345
Merged
246 code cleanup #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decembrya
requested review from
aniri,
bvizureanu and
idormenco
as code owners
sandrohanea
reviewed
Nov 15, 2020
| @@ -88,16 +84,16 @@ public async Task<PollingStationInfosDTO> GetRaspunsuriFormular(ObserverAnswersR | |||
| /// <code>IsFreeText = true</code></param> | |||
| /// <returns></returns> | |||
| [HttpPost] | |||
| [Authorize("Observer")] | |||
| public async Task<IActionResult> PostAnswer([FromBody] AnswerModelWrapper answerModel) | |||
| //[Authorize("Observer")] | |||
There was a problem hiding this comment.
Should this be commented out?
|
In order to ensure backward compatibility, I think we need to move this to a v2 endpoint and keep the old model for the v1 controller. |
idormenco
approved these changes
Jan 30, 2021
|
@sandrohanea we will merge it like this (knowing it will break the contract) and I will update the ui also. |
catileptic
approved these changes
Jan 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it fix?
First PR for
#246
cleanup and organise classes
rename everything to english
this PR affects only the Answer endpoints, namely:
GET /api/v1/answers
POST /api/v1/answers
GET /api/v1/answers/filledIn
GET /api/v1/answers/pollingStationInfo
How has it been tested?
tested manually and ran the available unit test
changes were done to some of the contracts, this will impact the client and changes will be needed there as well