Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(appium): missing await on some steps of runOnIOS and runOnAndroid #4018

Merged
merged 2 commits into from
Nov 29, 2023
Merged

fix(appium): missing await on some steps of runOnIOS and runOnAndroid #4018

merged 2 commits into from
Nov 29, 2023

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

  • Fix missing await on some steps of runOnIOS and runOnAndroid

Applicable helpers:

  • Appium

Type of change

  • 🐛 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent changed the title fix(appium): missing await on some steps fix(appium): missing await on some steps of runOnIOS and runOnAndroid Nov 22, 2023
@Arhell Arhell requested a review from DavertMik November 24, 2023 00:18
@kobenguyent kobenguyent merged commit a23688d into 3.x Nov 29, 2023
11 checks passed
@kobenguyent kobenguyent deleted the fix-async-runOnIos branch November 29, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell approved these changes

@DavertMik DavertMik Awaiting requested review from DavertMik

Assignees
No one assigned
Labels
appium bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobenguyent @Arhell