Skip to content

Commit

Permalink
Merge pull request #20 from codeclimate/pb-fix-categories
Browse files Browse the repository at this point in the history
Fix check-details keys
  • Loading branch information
pbrisbin committed Dec 7, 2015
2 parents a265a16 + f3c5f51 commit 4b049a0
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 26 deletions.
50 changes: 25 additions & 25 deletions lib/cc/engine/csslint/check_details.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,31 +4,31 @@ class CSSlint
class CheckDetails
ALL_RULES = {
# https://github.com/CSSLint/csslint/wiki/Rules
"net.csslint.Adjoiningclasses" => { categories: "Compatability" },
"net.csslint.Boxmodel" => { categories: "Bug Risk" },
"net.csslint.Boxsizing" => { categories: "Compatability" },
"net.csslint.Bulletprooffontface" => { categories: "Compatability" },
"net.csslint.Compatiblevendorprefixes" => { categories: "Compatability" },
"net.csslint.Displaypropertygrouping" => { categories: "Bug Risk" },
"net.csslint.Duplicatebackgroundimages" => { categories: "Bug Risk" },
"net.csslint.Duplicateproperties" => { categories: "Bug Risk" },
"net.csslint.Emptyrules" => { categories: "Bug Risk" },
"net.csslint.Fallbackcolors" => { categories: "Compatability" },
"net.csslint.Fontfaces" => { categories: "Bug Risk" },
"net.csslint.Gradients" => { categories: "Compatability" },
"net.csslint.Import" => { categories: "Bug Risk" },
"net.csslint.Knownproperties" => { categories: "Bug Risk" },
"net.csslint.Overqualifiedelements" => { categories: "Bug Risk" },
"net.csslint.Regexselectors" => { categories: "Bug Risk" },
"net.csslint.Shorthand" => { categories: "Bug Risk" },
"net.csslint.Starpropertyhack" => { categories: "Compatability" },
"net.csslint.Textindent" => { categories: "Compatability" },
"net.csslint.Underscorepropertyhack" => { categories: "Compatability" },
"net.csslint.Uniqueheadings" => { categories: "Duplication" },
"net.csslint.Universalselector" => { categories: "Bug Risk" },
"net.csslint.Unqualifiedattributes" => { categories: "Bug Risk" },
"net.csslint.Vendorprefix" => { categories: "Compatability" },
"net.csslint.Zerounits" => { categories: "Bug Risk" },
"net.csslint.Bewareofbrokenboxsize" => { categories: "Bug Risk" },
"net.csslint.Disallow@import" => { categories: "Bug Risk" },
"net.csslint.Disallowadjoiningclasses" => { categories: "Compatability" },
"net.csslint.Disallowduplicatebackgroundimages" => { categories: "Bug Risk" },
"net.csslint.Disallowduplicateproperties" => { categories: "Bug Risk" },
"net.csslint.Disallowemptyrules" => { categories: "Bug Risk" },
"net.csslint.Disallownegativetext-indent" => { categories: "Compatability" },
"net.csslint.Disallowoverqualifiedelements" => { categories: "Bug Risk" },
"net.csslint.Disallowpropertieswithanunderscoreprefix" => { categories: "Compatability" },
"net.csslint.Disallowpropertieswithastarprefix" => { categories: "Compatability" },
"net.csslint.Disallowselectorsthatlooklikeregexs" => { categories: "Bug Risk" },
"net.csslint.Disallowunitsfor0values" => { categories: "Bug Risk" },
"net.csslint.Disallowuniversalselector" => { categories: "Bug Risk" },
"net.csslint.Disallowunqualifiedattributeselectors" => { categories: "Bug Risk" },
"net.csslint.Disallowuseofbox-sizing" => { categories: "Compatability" },
"net.csslint.Don'tusetoomanywebfonts" => { categories: "Bug Risk" },
"net.csslint.Headingsshouldonlybedefinedonce" => { categories: "Duplication" },
"net.csslint.Requireallgradientdefinitions" => { categories: "Compatability" },
"net.csslint.Requirecompatiblevendorprefixes" => { categories: "Compatability" },
"net.csslint.Requirefallbackcolors" => { categories: "Compatability" },
"net.csslint.Requirepropertiesappropriatefordisplay" => { categories: "Bug Risk" },
"net.csslint.Requireshorthandproperties" => { categories: "Bug Risk" },
"net.csslint.Requirestandardpropertywithvendorprefix" => { categories: "Compatability" },
"net.csslint.Requireuseofknownproperties" => { categories: "Bug Risk" },
"net.csslint.Usethebulletproof@font-facesyntax" => { categories: "Compatability" },
}.freeze

DEFAULT_CATEGORY = "Style".freeze
Expand Down
2 changes: 1 addition & 1 deletion spec/cc/engine/csslint/check_details_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class CC::Engine::CSSlint
describe CheckDetails do
describe ".fetch" do
it "returns details for customized checks" do
details = CheckDetails.fetch("net.csslint.Import")
details = CheckDetails.fetch("net.csslint.Disallow@import")

expect(details.categories).to eq ["Bug Risk"]
expect(details.remediation_points).to eq 50_000
Expand Down

0 comments on commit 4b049a0

Please sign in to comment.