Add test for Edit package page

codedmonkey · Dec 19, 2024 · e5e87fc · e5e87fc
1 parent 956d31a
commit e5e87fc
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 4 deletions.
diff --git a/src/Validator/UniquePackageValidator.php b/src/Validator/UniquePackageValidator.php
@@ -30,7 +30,9 @@ public function validate(mixed $value, Constraint $constraint): void
             throw new UnexpectedValueException($value, Package::class);
         }
 
-        if ($this->packageRepository->findOneByName($value->getName())) {
+        $existingPackage = $this->packageRepository->findOneByName($value->getName());
+
+        if ($existingPackage && $existingPackage->getId() !== $value->getId()) {
             $this->context->buildViolation('A package with the name ' . $value->getName() . ' already exists.')
                 ->atPath('repositoryUrl')
                 ->addViolation();

diff --git a/...ts/Controller/ApiControllerPublicTest.php → ...nctionalTests/ApiControllerPublicTest.php b/...ts/Controller/ApiControllerPublicTest.php → ...nctionalTests/ApiControllerPublicTest.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace CodedMonkey\Dirigent\Tests\FunctionalTests\Controller;
+namespace CodedMonkey\Dirigent\Tests\FunctionalTests;
 
 use CodedMonkey\Dirigent\Tests\PublicKernel;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;

diff --git a/...board/DashboardPackagesControllerTest.php → ...Tests/DashboardPackagesControllerTest.php b/...board/DashboardPackagesControllerTest.php → ...Tests/DashboardPackagesControllerTest.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace CodedMonkey\Dirigent\Tests\FunctionalTests\Controller\Dashboard;
+namespace CodedMonkey\Dirigent\Tests\FunctionalTests;
 
 use CodedMonkey\Dirigent\Doctrine\Entity\User;
 use CodedMonkey\Dirigent\Doctrine\Repository\PackageRepository;
@@ -25,12 +25,31 @@ public function testAddVcsRepository(): void
             'package_add_vcs_form[repositoryUrl]' => 'https://github.com/php-fig/container',
         ]);
 
+        $this->assertResponseStatusCodeSame(302);
+
         /** @var PackageRepository $packageRepository */
         $packageRepository = $client->getContainer()->get(PackageRepository::class);
 
         $package = $packageRepository->findOneByName('psr/container');
-        self::assertNotNull($package);
+        self::assertNotNull($package, 'A package was created');
 
         $packageRepository->remove($package, true);
     }
+
+    public function testEdit(): void
+    {
+        $client = static::createClient();
+
+        /** @var UserRepository $userRepository */
+        $userRepository = $client->getContainer()->get(UserRepository::class);
+
+        /** @var User $user */
+        $user = $userRepository->findOneByUsername('owner');
+        $client->loginUser($user);
+
+        $client->request('GET', '/?routeName=dashboard_packages_edit&routeParams[packageName]=psr/log');
+        $client->submitForm('Save changes');
+
+        $this->assertResponseStatusCodeSame(302);
+    }
 }