Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [CG-10573] make clang dependency more explicit for debian linux to preven… #211

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

clee-codegen
Copy link
Contributor

@clee-codegen clee-codegen commented Jan 30, 2025

…t initial clang error

Motivation

Prevents getting an error when following the installation steps in contributions for the first time without seeing the clang tip at the bottom of the steps. The error may is embedded in uv logs and may not be immediately obvious.

Content

Add debian/ubuntu section to contribution section to prevent the first time setup error.

Testing

Please check the following before marking your PR as ready for review

Tested the installation steps on an Ubuntu machine.

  • I have added tests for my changes
  • I have updated the documentation or added new documentation as needed
  • I have read and agree to the Contributor License Agreement

@CLAassistant
Copy link

CLAassistant commented Jan 30, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ clee-codegen
❌ chris-nexus
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files

CONTRIBUTING.md Outdated Show resolved Hide resolved
rm uv.lock && uv sync --dev
```

- If `uv sync` fails due to a compilation error, ensure `clang` is installed and then rerun:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be clang or g++ on linux, not entirely sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can test this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without clang and the latest version of g++, I still get the error requiring clang.

Copy link
Contributor

@tomcodgen tomcodgen Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, you need clang or change CC var (export CC=gcc)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh ok

@clee-codegen clee-codegen requested a review from bagel897 January 30, 2025 18:08
@clee-codegen clee-codegen marked this pull request as ready for review January 30, 2025 18:08
@clee-codegen clee-codegen requested review from codegen-team and a team as code owners January 30, 2025 18:08
@clee-codegen clee-codegen enabled auto-merge (squash) February 5, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants