-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [CG-10573] make clang dependency more explicit for debian linux to preven… #211
base: develop
Are you sure you want to change the base?
chore: [CG-10573] make clang dependency more explicit for debian linux to preven… #211
Conversation
…t initial clang error
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files |
rm uv.lock && uv sync --dev | ||
``` | ||
|
||
- If `uv sync` fails due to a compilation error, ensure `clang` is installed and then rerun: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be clang or g++ on linux, not entirely sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can test this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without clang and the latest version of g++, I still get the error requiring clang.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, you need clang or change CC var (export CC=gcc
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh ok
…ides-for-sdk-contributing
…ides-for-sdk-contributing
…t initial clang error
Motivation
Prevents getting an error when following the installation steps in contributions for the first time without seeing the clang tip at the bottom of the steps. The error may is embedded in uv logs and may not be immediately obvious.
Content
Add debian/ubuntu section to contribution section to prevent the first time setup error.
Testing
Please check the following before marking your PR as ready for review
Tested the installation steps on an Ubuntu machine.