remove default ServiceMonitor #1132
Conversation
filariow
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
mfrancisc,
rsoaresd,
fbm3307 and
metlos
as code owners
Signed-off-by: Francesco Ilario <[email protected]>
filariow
force-pushed
the
service-monitor
branch
from
87496cb to
976b4df
Compare
Signed-off-by: Francesco Ilario <[email protected]>
|
/hold |
|
/lgtm |
|
@filariow any specific reason for putting it on hold? |
Yeah, sorry, I forgot to mention it. I'd like to merge redhat-appstudio/infra-deployments#5441 before this one |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, filariow, MatousJobanek, mfrancisc, xcoulon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
/unhold |
|
alexeykazakov
merged commit f255b6c
into
codeready-toolchain:master
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1132 +/- ##
==========================================
+ Coverage 79.51% 79.52% +0.01%
==========================================
Files 80 80
Lines 8087 8087
==========================================
+ Hits 6430 6431 +1
+ Misses 1472 1471 -1
Partials 185 185 |
Signed-off-by: Francesco Ilario [email protected]