Implementation of project page #50
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaelgohary
reviewed
Aug 21, 2024
Mahmoud-Emad
requested changes
Aug 27, 2024
| @@ -186,7 +186,7 @@ class ProjectMembersAPIView(GenericAPIView): | |||
| """This class to return all project members""" | |||
|
|
|||
| serializer_class = ProjectTeamSerializer | |||
| permission_classes = (HasProjectAccess,) | |||
There was a problem hiding this comment.
Why you removed the permission classes? please return them back and apply it on all classes
Comment on lines
+37
to
+39
| export type TestRun = { | ||
|
|
||
| } |
There was a problem hiding this comment.
Design this, check the serializer class to get familiar with the response
client/src/router/index.ts
Outdated
| @@ -10,7 +10,6 @@ import { createRouter, createWebHistory } from 'vue-router/auto' | |||
| const router = createRouter({ | |||
| history: createWebHistory(import.meta.env.BASE_URL), | |||
| routes: [ | |||
| { path: '/', component: () => import('@/pages/DashboardView.vue') }, | |||
There was a problem hiding this comment.
Don't we need the DashboardView anymore?
| @@ -132,14 +135,17 @@ | |||
| .then((response: any) => { | |||
| }) | |||
| .catch((err: any) => { | |||
| let description = 'Can not search for projects' | |||
There was a problem hiding this comment.
Suggested change
| let description = 'Can not search for projects' | |
| let description = 'Unable to search for projects.' |
| }) | ||
| .catch((err: any) => { | ||
| let description = 'Can not get projects' |
There was a problem hiding this comment.
Suggested change
| let description = 'Can not get projects' | |
| let description = 'Unable to get projects.' |
| @@ -103,17 +103,20 @@ | |||
| const getPage = async (page: number) => { | |||
| getProjects(page).then((response: any) => { | |||
| projects.value = response.data.results | |||
| // count.value = response.body.total_count | |||
| count.value = response.data.total_count | |||
There was a problem hiding this comment.
if you want to use pagination, let's do it
| showProgressBar: true, | ||
| timeout: 7_000, | ||
| type: 'success', | ||
| }) | ||
| }) | ||
| .catch((err: any) => { | ||
| let description = 'Can not create project' |
There was a problem hiding this comment.
Suggested change
| let description = 'Can not create project' | |
| let description = 'Unable to create a new project.' |
| @@ -90,21 +90,24 @@ | |||
| .then((response: any) => { | |||
| notifier.notify({ | |||
| title: 'Success', | |||
| description: 'Project created Successfully', | |||
| description: response.data.message, | |||
There was a problem hiding this comment.
also, you could do
Suggested change
| description: response.data.message, | |
| description: response.data.message || 'Project created Successfully', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create routes for the website and Create a navigation bar to use the router.
Changes
search bar
list of projects
delete project
update project
recent activities ( create project, delete project )
project statistics
project team
Incomplete test runs
recent activity ( add components within a project)
title
description
github repo link
Related Issues