Cleanup blockexchange blockAddress handling #1051
Open
+24
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbierens
changed the base branch from
master
to
feature/blkexc-peer-selection
dryajov
force-pushed
the
feature/blkexc-peer-selection
branch
2 times, most recently
from
afbfadb to
af0c9d8
Compare
benbierens
force-pushed
the
feature/blockexc-cleanup-blockaddrs-handling
branch
from
3e706b3 to
8318eac
Compare
gmega
reviewed
Jan 14, 2025
| toSeq(b.pendingBlocks.wantListCids) | ||
| .filter do(cid: Cid) -> bool: | ||
| not b.peers.anyIt( cid in it.peerHaveCids )) | ||
| toSeq(b.pendingBlocks.wantList).filterIt(b.peers.peersHave(it).len == 0) |
There was a problem hiding this comment.
I'm trusting those two things are the same....
gmega
reviewed
Jan 14, 2025
| @@ -130,19 +130,6 @@ iterator wantList*(p: PendingBlocksManager): BlockAddress = | |||
| for a in p.blocks.keys: | |||
| yield a | |||
|
|
|||
| iterator wantListBlockCids*(p: PendingBlocksManager): Cid = | |||
There was a problem hiding this comment.
I guess this is the actual dead code?
There was a problem hiding this comment.
Indeed, unused code.
gmega
reviewed
Jan 14, 2025
| @@ -38,12 +38,6 @@ type | |||
| proc peerHave*(self: BlockExcPeerCtx): seq[BlockAddress] = | |||
| toSeq(self.blocks.keys) | |||
|
|
|||
| proc peerHaveCids*(self: BlockExcPeerCtx): HashSet[Cid] = | |||
benbierens
added
the
Client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of CIDs and BlockAddresses in this part of the code could use a little clean-up. Some of this is unused code, left-over from the announce-every-block days. Some of the code can be easily made redundant by concolidating some knowledge where possible. Every little bit we clean up, we don't have to carry forward and maintain.