Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update nim version #1052

Merged
merged 47 commits into from
Jan 10, 2025
Merged
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
b5af96f
Move to version 2.0.6
2-towns Nov 28, 2024
ca2b63c
Update nim-confutils submodule to latest version
2-towns Nov 28, 2024
ef3274b
Update dependencies
2-towns Dec 18, 2024
34f5e00
Update Nim version to 2.0.12
2-towns Dec 18, 2024
7c9b607
Add gcsafe pragma
2-towns Dec 18, 2024
0e00f0c
Add missing import
2-towns Dec 18, 2024
0ecf3f7
Update specific conf for Nim 2.x
2-towns Dec 18, 2024
4935494
Fix method signatures
2-towns Dec 18, 2024
a1c8c94
Revert erasure coding attempt to fix bug
2-towns Dec 18, 2024
599e868
More gcsafe pragma
2-towns Dec 18, 2024
a2f0528
Duplicate code from libp2p because it is not exported anymore
2-towns Dec 18, 2024
a2f09b2
Fix camelcase function names
2-towns Dec 18, 2024
902c6dc
Use alreadySeen because need is not a bool anymore
2-towns Dec 18, 2024
83b4943
newLPStreamReadError does not exist anymore so use another error
2-towns Dec 18, 2024
daadffe
Replace ValidIpAddress by IpAddress
2-towns Dec 18, 2024
d6b1781
Add gcsafe pragma
2-towns Dec 26, 2024
0724d7f
Restore maintenance parameter deleted by mistake when removing esasur…
2-towns Dec 26, 2024
6ad496d
Update method signatures
2-towns Dec 26, 2024
5c80a84
Copy LPStreamReadError code from libp2p which was removed
2-towns Dec 26, 2024
6b64c25
Fix camel case
2-towns Dec 26, 2024
627e6ae
Fix enums in tests
2-towns Dec 26, 2024
51a4054
Fix camel case
2-towns Dec 26, 2024
ab39da8
Extract node components to a variable to make Nim 2 happy
2-towns Dec 26, 2024
3f9f421
Update the tests using ValidIpAddress to IpAddress
2-towns Dec 26, 2024
d2388a3
Fix cast for value which is already an option
2-towns Dec 27, 2024
b9222d0
Merge branch 'master' into chore/update-nim-version
2-towns Dec 30, 2024
d9eca3b
Set nim version to 2.0.x for CI
2-towns Jan 2, 2025
696f66d
Set nim version to 2.0.x for CI
2-towns Jan 2, 2025
56d2186
Move to miniupnp version 2.2.4 to avoid symlink error
2-towns Jan 3, 2025
1ecad68
Set core.symlinks to false for Windows for miniupnp >= 2.2.5 support
2-towns Jan 6, 2025
7bdbd87
Update to Nim 2.0.14
2-towns Jan 7, 2025
dfcdac6
Update CI nim versions to 2.0.14
2-towns Jan 7, 2025
f24d264
Try with GCC 14
2-towns Jan 8, 2025
fdba4e7
Replace apt-fast by apt-get
2-towns Jan 8, 2025
251d286
Update ubuntu runner to latest
2-towns Jan 8, 2025
b5848da
Use Ubuntu 20.04 for coverage
2-towns Jan 9, 2025
801f6b7
Disable CI cache for coverage
2-towns Jan 9, 2025
2c436db
Add coverage property description
2-towns Jan 9, 2025
958df72
Remove commented test
2-towns Jan 9, 2025
08ced59
Check the node value of seen instead of using alreadySeen
2-towns Jan 9, 2025
00e3f0e
Merge branch 'master' into chore/update-nim-version
2-towns Jan 9, 2025
10bc903
Fix the merge. The taskpool work was reverted.
2-towns Jan 9, 2025
66d1c5b
Update nim-ethers submodule
2-towns Jan 9, 2025
943ca8a
Merge branch 'master' into chore/update-nim-version
2-towns Jan 10, 2025
fb14b60
Remove deprecated ValidIpAddress. Fix missing case and imports.
2-towns Jan 10, 2025
5cbb43b
Fix a weird issue where nim-confutils cannot find NatAny
2-towns Jan 10, 2025
0d71b0a
Fix tests and remove useless static keyword
2-towns Jan 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix enums in tests
2-towns committed Dec 26, 2024

Verified

This commit was signed with the committer’s verified signature.
2-towns Arnaud
commit 627e6ae5a63ddea867bcf19d6d709ed8ce30b865
4 changes: 2 additions & 2 deletions tests/codex/sales/testsalesagent.nim
Original file line number Diff line number Diff line change
@@ -101,7 +101,7 @@ asyncchecksuite "Sales agent":
clock.set(market.requestExpiry[request.id] + 1)
check eventually onCancelCalled

for requestState in {RequestState.New, Started, Finished, Failed}:
for requestState in {RequestState.New, RequestState.Started, RequestState.Finished, RequestState.Failed}:
test "onCancelled is not called when request state is " & $requestState:
agent.start(MockState.new())
await agent.subscribe()
@@ -110,7 +110,7 @@ asyncchecksuite "Sales agent":
await sleepAsync(100.millis)
check not onCancelCalled

for requestState in {RequestState.Started, Finished, Failed}:
for requestState in {RequestState.Started, RequestState.Finished, RequestState.Failed}:
test "cancelled future is finished when request state is " & $requestState:
agent.start(MockState.new())
await agent.subscribe()