Feat/#56 회사 인증 테스트코드 작성 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈번호
close: #56
작업 내용 설명
리뷰어에게 한마디
Fixture를 dto 따로 entity따로 만들지말고 그냥 domain 별로 한 클래스 파일에 모든 dto랑 해당 패키지에서 쓰는 값 객체, entity까지 다 만드는거 어떤가요?
@Transactionalpublic void delete(Long userId) {
userService.deleteUser(userId);
refreshTokenRepository.deleteById(userId);
}
AuthService같은거 구조 어떻게 짤지 내일 얘기해보시죠