chore: add format check to typescript packages (#254)

coinbase · Feb 4, 2025 · b006ddd · b006ddd
1 parent 887399f
commit b006ddd
Show file tree

Hide file tree

Showing 12 changed files with 70 additions and 15 deletions.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -104,7 +104,7 @@ jobs:
       - name: Run linters
         run: poetry run make lint
 
-  lint-agentkit-typescript:
+  lint-typescript:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -114,9 +114,8 @@ jobs:
           cache: "npm"
       # Install dependencies in parent directory first
       - run: npm install
-      # Then install and lint in working directory
-      - name: Install and lint AgentKit
+      # formatting/lint in working directory
+      - name: Check formatting/lint
         run: |
-          npm install
+          npm run format:check
           npm run lint
-          npm run format
diff --git a/package.json b/package.json
@@ -16,8 +16,8 @@
     "clean": "turbo run clean",
     "docs": "turbo run docs",
     "dev": "turbo run dev",
-    "format": "prettier -c .prettierrc --write \"**/*.{ts,js,cjs,json,md}\"",
-    "format:check": "prettier -c .prettierrc --check \"**/*.{ts,js,cjs,json,md}\"",
+    "format": "turbo run format",
+    "format:check": "turbo run format:check",
     "lint:fix": "turbo run lint:fix",
     "test:types": "turbo run test:types"
   },

diff --git a/typescript/examples/langchain-cdp-chatbot/.prettierignore b/typescript/examples/langchain-cdp-chatbot/.prettierignore
@@ -0,0 +1,7 @@
+docs/
+dist/
+coverage/
+.github/
+src/client
+**/**/*.json
+*.md
diff --git a/typescript/examples/langchain-cdp-chatbot/.prettierrc b/typescript/examples/langchain-cdp-chatbot/.prettierrc
@@ -0,0 +1,11 @@
+{
+  "tabWidth": 2,
+  "useTabs": false,
+  "semi": true,
+  "singleQuote": false,
+  "trailingComma": "all",
+  "bracketSpacing": true,
+  "arrowParens": "avoid",
+  "printWidth": 100,
+  "proseWrap": "never"
+}
diff --git a/typescript/examples/langchain-cdp-chatbot/package.json b/typescript/examples/langchain-cdp-chatbot/package.json
@@ -8,9 +8,9 @@
     "start": "NODE_OPTIONS='--no-warnings' ts-node ./chatbot.ts",
     "dev": "nodemon ./chatbot.ts",
     "lint": "eslint -c .eslintrc.json *.ts",
-    "lint-fix": "eslint -c .eslintrc.json *.ts --fix",
-    "format": "prettier -c .prettierrc --write \"**/*.{ts,js,cjs,json,md}\"",
-    "format-check": "prettier -c .prettierrc --check \"**/*.{ts,js,cjs,json,md}\""
+    "lint:fix": "eslint -c .eslintrc.json *.ts --fix",
+    "format": "prettier --write \"**/*.{ts,js,cjs,json,md}\"",
+    "format:check": "prettier -c .prettierrc --check \"**/*.{ts,js,cjs,json,md}\""
   },
   "dependencies": {
     "@coinbase/agentkit": "^0.1.0",

diff --git a/typescript/examples/langchain-farcaster-chatbot/.prettierignore b/typescript/examples/langchain-farcaster-chatbot/.prettierignore
@@ -0,0 +1,7 @@
+docs/
+dist/
+coverage/
+.github/
+src/client
+**/**/*.json
+*.md
diff --git a/typescript/examples/langchain-farcaster-chatbot/.prettierrc b/typescript/examples/langchain-farcaster-chatbot/.prettierrc
@@ -0,0 +1,11 @@
+{
+  "tabWidth": 2,
+  "useTabs": false,
+  "semi": true,
+  "singleQuote": false,
+  "trailingComma": "all",
+  "bracketSpacing": true,
+  "arrowParens": "avoid",
+  "printWidth": 100,
+  "proseWrap": "never"
+}
diff --git a/typescript/examples/langchain-farcaster-chatbot/package.json b/typescript/examples/langchain-farcaster-chatbot/package.json
@@ -7,9 +7,9 @@
     "start": "NODE_OPTIONS='--no-warnings' ts-node ./chatbot.ts",
     "dev": "nodemon ./chatbot.ts",
     "lint": "eslint -c .eslintrc.json *.ts",
-    "lint-fix": "eslint -c .eslintrc.json *.ts --fix",
+    "lint:fix": "eslint -c .eslintrc.json *.ts --fix",
     "format": "prettier -c .prettierrc --write \"**/*.{ts,js,cjs,json,md}\"",
-    "format-check": "prettier -c .prettierrc --check \"**/*.{ts,js,cjs,json,md}\""
+    "format:check": "prettier -c .prettierrc --check \"**/*.{ts,js,cjs,json,md}\""
   },
   "dependencies": {
     "@coinbase/agentkit": "^0.1.0",

diff --git a/typescript/examples/langchain-twitter-chatbot/.prettierignore b/typescript/examples/langchain-twitter-chatbot/.prettierignore
@@ -0,0 +1,7 @@
+docs/
+dist/
+coverage/
+.github/
+src/client
+**/**/*.json
+*.md
diff --git a/typescript/examples/langchain-twitter-chatbot/.prettierrc b/typescript/examples/langchain-twitter-chatbot/.prettierrc
@@ -0,0 +1,11 @@
+{
+  "tabWidth": 2,
+  "useTabs": false,
+  "semi": true,
+  "singleQuote": false,
+  "trailingComma": "all",
+  "bracketSpacing": true,
+  "arrowParens": "avoid",
+  "printWidth": 100,
+  "proseWrap": "never"
+}
diff --git a/typescript/examples/langchain-twitter-chatbot/package.json b/typescript/examples/langchain-twitter-chatbot/package.json
@@ -8,9 +8,9 @@
     "start": "NODE_OPTIONS='--no-warnings' ts-node ./chatbot.ts",
     "dev": "nodemon ./chatbot.ts",
     "lint": "eslint -c .eslintrc.json *.ts",
-    "lint-fix": "eslint -c .eslintrc.json *.ts --fix",
+    "lint:fix": "eslint -c .eslintrc.json *.ts --fix",
     "format": "prettier -c .prettierrc --write \"**/*.{ts,js,cjs,json,md}\"",
-    "format-check": "prettier -c .prettierrc --check \"**/*.{ts,js,cjs,json,md}\""
+    "format:check": "prettier -c .prettierrc --check \"**/*.{ts,js,cjs,json,md}\""
   },
   "dependencies": {
     "@coinbase/agentkit": "^0.1.0",

diff --git a/typescript/framework-extensions/langchain/package.json b/typescript/framework-extensions/langchain/package.json
@@ -7,7 +7,9 @@
   "license": "Apache-2.0",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
-  "files": ["dist"],
+  "files": [
+    "dist"
+  ],
   "scripts": {
     "build": "tsc",
     "lint": "eslint -c .eslintrc.json \"src/**/*.ts\"",