Get Balance for Other Wallets Fixes #291 #293
Open
+17
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
arnavmehta7
changed the title
0xRAG
added
enhancement
0xRAG
requested changes
Feb 11, 2025
There was a problem hiding this comment.
Thanks for the contribution @arnavmehta7! Please see my comments
| from pydantic import BaseModel, Field | ||
|
|
||
| from cdp_agentkit_core.actions import CdpAction | ||
|
|
||
| GET_BALANCE_PROMPT = """ | ||
| This tool will get the balance of all the addresses in the wallet for a given asset. | ||
| This tool will get the balance of address. |
There was a problem hiding this comment.
Please see suggestion
Suggested change
| This tool will get the balance of address. | |
| This tool will get the balance of all the addresses in the wallet for a given asset, or for a user-specified address if provided. |
| @@ -18,10 +19,14 @@ class GetBalanceInput(BaseModel): | |||
| ..., | |||
| description="The asset ID to get the balance for, e.g. `eth`, `0x036CbD53842c5426634e7929541eC2318f3dCF7e`", | |||
| ) | |||
| address_to_fund: Optional[str] = Field( | |||
| @@ -18,10 +19,14 @@ class GetBalanceInput(BaseModel): | |||
| ..., | |||
| description="The asset ID to get the balance for, e.g. `eth`, `0x036CbD53842c5426634e7929541eC2318f3dCF7e`", | |||
| ) | |||
| address_to_fund: Optional[str] = Field( | |||
| None, | |||
| description="The address to fund. If not provided, the default address of the wallet will be used.", | |||
There was a problem hiding this comment.
Please see suggestion
Suggested change
| description="The address to fund. If not provided, the default address of the wallet will be used.", | |
| description="The address to get the balance for. If not provided, addresses of the wallet will be used.", |
|
|
||
|
|
||
| def get_balance(wallet: Wallet, asset_id: str) -> str: | ||
| """Get balance for all addresses in the wallet for a given asset. | ||
| def get_balance(wallet: Wallet, asset_id: str, address_to_fund: Optional[str]) -> str: |
0xRAG
added
changes requested
|
Review Error for 0xRAG @ 2025-02-11 15:41:15 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #291
Added ability to fetch other wallet's balances if some specific address is supplied in prompt
Pros:
Example SS:
