Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Balance for Other Wallets Fixes #291 #293

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Get Balance for Other Wallets Fixes #291 #293

wants to merge 2 commits into from
+17 −8

Conversation

arnavmehta7
Copy link

@arnavmehta7 arnavmehta7 commented Feb 7, 2025 •
edited
Loading

Fixes #291
Added ability to fetch other wallet's balances if some specific address is supplied in prompt

Pros:

  • Supports Previous Implementation
  • Allows checking info for more wallets/external wallets

Example SS:
image

@cb-heimdall
Copy link

cb-heimdall commented Feb 7, 2025 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@arnavmehta7 arnavmehta7 changed the title changed logic to support both current wallet + other wallets which us… Get Balance for Other Wallets Fixes #291 Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get Balances for addresses over network other than system's wallet
2 participants
@arnavmehta7 @cb-heimdall