Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable source maps during the build process to simplify debugging. #277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

irux
Copy link

@irux irux commented Feb 6, 2025

What changed? Why?

I just changed the source maps when building the library

Qualified Impact

Currently, the library is quite new and serves as a framework for building new tools. However, its documentation is still limited, making it difficult to understand its inner workings without attaching a debugger. Adding source maps will make debugging much easier and more convenient for users who install the package and begin to use the library.

@cb-heimdall
Copy link

cb-heimdall commented Feb 6, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@0xRAG
Copy link
Contributor

0xRAG commented Feb 6, 2025

Hey @irux thanks for this. FYI you will need to enable commit signing in order to merge. See: https://docs.github.com/en/authentication/managing-commit-signature-verification/adding-a-gpg-key-to-your-github-account

@John-peterson-coinbase John-peterson-coinbase added enhancement New feature or request triaged changes requested PR / Issue has changes requested cherry labels Feb 10, 2025
@0xRAG 0xRAG removed the triaged label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested PR / Issue has changes requested cherry enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants