Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: viem chainId from number to string #294

Merged
merged 1 commit into from
Feb 7, 2025
Merged

fix: viem chainId from number to string #294

merged 1 commit into from
Feb 7, 2025
+1 −1

Conversation

azf20
Copy link
Contributor

@azf20 azf20 commented Feb 7, 2025

What changed? Why?

One-liner: viem's chainId is a number, agentkit expects a string

Qualified Impact

Avoids potential footgun when action providers are checking networks e.g. in this line

@cb-heimdall
Copy link

cb-heimdall commented Feb 7, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@John-peterson-coinbase John-peterson-coinbase merged commit 691e4f9 into coinbase:master Feb 7, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-peterson-coinbase John-peterson-coinbase John-peterson-coinbase approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azf20 @cb-heimdall @John-peterson-coinbase