Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.0.6-beta #18

Merged
merged 5 commits into from
Feb 21, 2024
Merged

v0.0.6-beta #18

merged 5 commits into from
Feb 21, 2024

Conversation

yangkenneth
Copy link
Contributor

  • Add ClientOptions to Support Additional Inputs for Client
  • Fix Client Side Signature Verification
  • Remove aws-sdk-go Dependencies

@yangkenneth yangkenneth changed the title V0.0.6 beta v0.0.6 beta Feb 20, 2024
@yangkenneth yangkenneth requested a review from Sneh1999 February 20, 2024 18:25
@yangkenneth yangkenneth changed the title v0.0.6 beta v0.0.6-beta Feb 20, 2024
Sneh1999
Sneh1999 approved these changes Feb 20, 2024
View reviewed changes
Copy link

@Sneh1999 Sneh1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits! but otherwise LGTM!

pkg/client/client.go Show resolved Hide resolved
pkg/client/client.go Show resolved Hide resolved
@cb-heimdall
Copy link

Review Error for Sneh1999 @ 2024-02-20 21:31:24 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@cb-heimdall
Copy link

Review Error for snehkoul-cb @ 2024-02-20 23:25:43 UTC
User must have write permissions to review

@cb-heimdall
Copy link

Review Error for snehkoul-cb @ 2024-02-20 23:26:07 UTC
User must have write permissions to review

@cb-heimdall
Copy link

Review Error for snehkoul-cb @ 2024-02-21 10:44:08 UTC
User must have write permissions to review

@yangkenneth yangkenneth merged commit f3a0f7a into coinbase:master Feb 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snehkoul-cb snehkoul-cb snehkoul-cb approved these changes

@Sneh1999 Sneh1999 Sneh1999 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yangkenneth @cb-heimdall @Sneh1999 @snehkoul-cb