Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add sync.RWMutex to headerforwarder map #511

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

potterbm-cb
Copy link
Contributor

Motivation

This utility was part of a proof-of-concept and this is an attempt to move it closer to a production-ready state

Solution

Header forwarder was failing with fatal error: concurrent map writes when under heavy load. This change adds a read/write aware locking mechanism to prevent concurrent writes (concurrent reads will not block unless there is a write happening)

@cb-heimdall
Copy link

cb-heimdall commented Nov 26, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@potterbm-cb potterbm-cb merged commit 07dc44a into master Nov 26, 2024
11 checks passed
@potterbm-cb potterbm-cb deleted the bryan/headerforwarder-concurrency-safe branch November 26, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants