Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code snippet spacing #1644

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix code snippet spacing #1644

merged 1 commit into from
Nov 20, 2024

Conversation

brendan-defi
Copy link
Contributor

@brendan-defi brendan-defi commented Nov 20, 2024

What changed? Why?

  • fixed spacing on homepage code snippets

fix:
image

current:
image

Notes to reviewers

How has it been tested?
locally

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 20, 2024
@@ -17,7 +17,7 @@ export const checkoutDemoCode = `
</Checkout>
)
}
`;
`;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without the indent here, the code snippet can be cut-off by the preview container. with the indents, the scroll will always take the reader to the bottom of the string.

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 5:59pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 5:59pm

@cpcramer
Copy link
Contributor

cpcramer commented Nov 20, 2024

For UI changes, can you include screenshots in the PR description? Makes it much easier to review!

@brendan-defi
Copy link
Contributor Author

brendan-defi commented Nov 20, 2024

For UI changes, can you include screenshots in the PR description? Makes it much easier to review!

yeah, my bad, added screenshot to description

@brendan-defi brendan-defi merged commit 880c6cc into main Nov 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

4 participants