-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix code snippet spacing #1644
fix code snippet spacing #1644
Conversation
@@ -17,7 +17,7 @@ export const checkoutDemoCode = ` | |||
</Checkout> | |||
) | |||
} | |||
`; | |||
`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without the indent here, the code snippet can be cut-off by the preview container. with the indents, the scroll will always take the reader to the bottom of the string.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
For UI changes, can you include screenshots in the PR description? Makes it much easier to review! |
yeah, my bad, added screenshot to description |
What changed? Why?
fix:
![image](https://private-user-images.githubusercontent.com/39347156/388212431-b3a4a585-0477-4be8-92de-de5c6a99e037.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMDM1MjIsIm5iZiI6MTczOTEwMzIyMiwicGF0aCI6Ii8zOTM0NzE1Ni8zODgyMTI0MzEtYjNhNGE1ODUtMDQ3Ny00YmU4LTkyZGUtZGU1YzZhOTllMDM3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDEyMTM0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRlY2I4OWUyZGZlZWQ3ZGI3ZjgwYzliYWQyNjkxOTQzMzUyZWY1ZGYyNmYwZjlhNTBlMjllZTI1NjI2ZmIxYWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.j5bJ34ndoj8gnMCrQC6W-JmIFYrV4pwT3EGPiHtkcNM)
current:
![image](https://private-user-images.githubusercontent.com/39347156/388212521-93537dcb-6b42-4c78-8190-15910c21067c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMDM1MjIsIm5iZiI6MTczOTEwMzIyMiwicGF0aCI6Ii8zOTM0NzE1Ni8zODgyMTI1MjEtOTM1MzdkY2ItNmI0Mi00Yzc4LTgxOTAtMTU5MTBjMjEwNjdjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDEyMTM0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZhMmY0MGYzOTdiMjIxNjlkM2EzM2YyZGM3MDdhMjdhM2ZmOWUyOWM4ZmEzZGE1NzJhMDYyMmYwNDhlNzg2ZjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.OfH-qUHjOjYxEoacB50SxT5qc9uvxjBhpNUrCoTItn4)
Notes to reviewers
How has it been tested?
locally