-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add onchainkit-context #1899
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
a95870f
to
6657f3d
Compare
6657f3d
to
62a3e7c
Compare
62a3e7c
to
cf269d1
Compare
cf269d1
to
1261517
Compare
bea5de6
to
f226985
Compare
f226985
to
d16db92
Compare
d16db92
to
857450f
Compare
brendan-defi
reviewed
Feb 3, 2025
to: toToken, | ||
useAggregator: false, | ||
}, | ||
RequestContext.Wallet, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking question: when should we allow this to be hook
vs hardcoded to the "default" component in which it's used?
brendan-defi
approved these changes
Feb 3, 2025
dschlabach
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Adding context parameter to track the context in which our rpc-proxy API requests were used. For example, this will allow us to differentiate in our analytics whether a swap was initiated from a Buy component, Swap component or directly from an API.
Notes to reviewers
How has it been tested?