Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add onchainkit-context #1899

Merged
merged 4 commits into from
Feb 3, 2025
Merged

feat: add onchainkit-context #1899

merged 4 commits into from
Feb 3, 2025

Conversation

alessey
Copy link
Contributor

@alessey alessey commented Jan 29, 2025

What changed? Why?
Adding context parameter to track the context in which our rpc-proxy API requests were used. For example, this will allow us to differentiate in our analytics whether a swap was initiated from a Buy component, Swap component or directly from an API.

Notes to reviewers

How has it been tested?

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 9:47pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 9:47pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 9:47pm

@alessey alessey force-pushed the alessey/add-onchainkit-referrer branch from a95870f to 6657f3d Compare January 29, 2025 21:36
@alessey alessey changed the title Alessey/add onchainkit referrer feat: add onchainkit-referrer Jan 29, 2025
@alessey alessey force-pushed the alessey/add-onchainkit-referrer branch from 6657f3d to 62a3e7c Compare January 29, 2025 21:39
@alessey alessey force-pushed the alessey/add-onchainkit-referrer branch from 62a3e7c to cf269d1 Compare January 29, 2025 21:52
@alessey alessey force-pushed the alessey/add-onchainkit-referrer branch from cf269d1 to 1261517 Compare January 30, 2025 15:19
@alessey alessey force-pushed the alessey/add-onchainkit-referrer branch from bea5de6 to f226985 Compare January 31, 2025 21:17
@alessey alessey force-pushed the alessey/add-onchainkit-referrer branch from f226985 to d16db92 Compare January 31, 2025 21:35
to: toToken,
useAggregator: false,
},
RequestContext.Wallet,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking question: when should we allow this to be hook vs hardcoded to the "default" component in which it's used?

@alessey alessey merged commit e16bc49 into main Feb 3, 2025
16 checks passed
@alessey alessey deleted the alessey/add-onchainkit-referrer branch February 3, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants