fix: reset amount inputs after successful deposit/withdrawal #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcramer
reviewed
Feb 10, 2025
| @@ -41,11 +35,35 @@ export function WithdrawButton({ className }: WithdrawButtonReact) { | |||
| [updateLifecycleStatus], | |||
| ); | |||
|
|
|||
| const handleOnSuccess = useCallback( | |||
| (res: TransactionResponse) => { | |||
| console.log('res:', res); | |||
cpcramer
reviewed
Feb 10, 2025
| @@ -16,9 +16,10 @@ export function buildWithdrawFromMorphoTx({ | |||
| amount, | |||
| receiverAddress, | |||
| }: WithdrawFromMorphoParams): Call[] { | |||
| console.log('amount:', amount); | |||
cpcramer
reviewed
Feb 10, 2025
| const withdrawTxData = encodeFunctionData({ | ||
| abi: MORPHO_VAULT_ABI, | ||
| functionName: 'withdraw', | ||
| functionName: 'redeem', // redeem is the number of *shares*, withdraw is the number of *assets* |
There was a problem hiding this comment.
I'm still unsure about the difference between shares and assets after reading this. That doesn't need to be clarified here, just calling out
There was a problem hiding this comment.
Fair point, I have another PR in the pipe to clean up some of this stuff, I can try and improve it then
cpcramer
previously approved these changes
Feb 10, 2025
cpcramer
approved these changes
Feb 10, 2025
alessey
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR includes the following behavior changes for Earn:
redeemmethod instead ofwithdrawmethod on vault contract for greater decimal precisionNotes to reviewers
How has it been tested?