Skip to content

Commit

Permalink
Disable the check for circular dependencies because of an issue with
Browse files Browse the repository at this point in the history
plone.app.discussion

See plone/plone.app.discussion#253
  • Loading branch information
ale-rt committed Jan 14, 2025
1 parent 4f2fc07 commit bb852f1
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 30 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/meta.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ jobs:
uses: plone/meta/.github/workflows/release_ready.yml@main
circular:
uses: plone/meta/.github/workflows/circular.yml@main
# XXX Disabled until plone.app.discussion is free from plone.api
# see: https://github.com/plone/plone.app.discussion/pull/253
if: false

##
# To modify the list of default jobs being created add in .meta.toml:
Expand Down
62 changes: 32 additions & 30 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -174,36 +174,38 @@ commands =
python -m build --sdist
twine check dist/*

[testenv:circular]
description = ensure there are no cyclic dependencies
use_develop = true
skip_install = false
# Here we must always constrain the package deps to what is already installed,
# otherwise we simply get the latest from PyPI, which may not work.
constrain_package_deps = true
set_env =

##
# Specify extra test environment variables in .meta.toml:
# [tox]
# test_environment_variables = """
# PIP_EXTRA_INDEX_URL=https://my-pypi.my-server.com/
# """
##
allowlist_externals =
sh
deps =
pipdeptree
pipforester
-c https://dist.plone.org/release/6.0-dev/constraints.txt

commands =
# Generate the full dependency tree
sh -c 'pipdeptree -j > forest.json'
# Generate a DOT graph with the circular dependencies, if any
pipforester -i forest.json -o forest.dot --cycles
# Report if there are any circular dependencies, i.e. error if there are any
pipforester -i forest.json --check-cycles -o /dev/null
# XXX: this is commented because plone.app.discussion wrongly depends on plone.api
# See https://github.com/plone/plone.app.discussion/pull/253
# [testenv:circular]
# description = ensure there are no cyclic dependencies
# use_develop = true
# skip_install = false
# # Here we must always constrain the package deps to what is already installed,
# # otherwise we simply get the latest from PyPI, which may not work.
# constrain_package_deps = true
# set_env =
#
# ##
# # Specify extra test environment variables in .meta.toml:
# # [tox]
# # test_environment_variables = """
# # PIP_EXTRA_INDEX_URL=https://my-pypi.my-server.com/
# # """
# ##
# allowlist_externals =
# sh
# deps =
# pipdeptree
# pipforester
# -c https://dist.plone.org/release/6.0-dev/constraints.txt
#
# commands =
# # Generate the full dependency tree
# sh -c 'pipdeptree -j > forest.json'
# # Generate a DOT graph with the circular dependencies, if any
# pipforester -i forest.json -o forest.dot --cycles
# # Report if there are any circular dependencies, i.e. error if there are any
# pipforester -i forest.json --check-cycles -o /dev/null


##
Expand Down

0 comments on commit bb852f1

Please sign in to comment.