Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use z3c.autoinclude.plugin #25

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Use z3c.autoinclude.plugin #25

merged 1 commit into from
Sep 13, 2021

Conversation

wesleybl
Copy link
Member

Fix #7

@wesleybl wesleybl requested review from jensens and ale-rt September 13, 2021 15:01
@ale-rt
Copy link
Member

ale-rt commented Sep 13, 2021

I have no opinion on this one, but have a look at plone/Products.CMFPlone#3053

@wesleybl
Copy link
Member Author

wesleybl commented Sep 13, 2021 •
edited
Loading

I have no opinion on this one, but have a look at plone/Products.CMFPlone#3053

Well, we don't even have plone.autoinclude for Plone 6 yet. So I don't see a problem using z3c.autoinclude here.

@mauritsvanrees are there plans to use plone.autoinclude officially in Plone 6? It would be great to install Plone with pip.

@mauritsvanrees
Copy link
Member

Well, we don't even have plone.autoinclude for Plone 6 yet. So I don't see a problem using z3c.autoinclude here.

plone.autoinclude is able to read 'old' z3c.autoinclude entry points as well, so this is fine.

@mauritsvanrees are there plans to use plone.autoinclude officially in Plone 6? It would be great to install Plone with pip.

Yes, I would want to include it.
But actually you can install Plone with pip already (some problems with newer pip dependency resolver though, unrelated to any autoinclude stuff), and z3c.autoinclude still seems to work there, except for the includeDependencies stuff, which we don't want anyway.

@mauritsvanrees mauritsvanrees merged commit 0fb085d into master Sep 13, 2021
@mauritsvanrees mauritsvanrees deleted the z3c_autoinclude branch September 13, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

@jensens jensens Awaiting requested review from jensens

@ale-rt ale-rt Awaiting requested review from ale-rt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use z3c.autoinclude plugin
3 participants
@wesleybl @ale-rt @mauritsvanrees