-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightMLFlow 0.7.0
#25
Open
mrkaye97
wants to merge
13
commits into
main
Choose a base branch
from
0.7.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyelhabr
reviewed
Jul 8, 2022
|
||
bucket <- str_extract( | ||
without_s3_prefix, | ||
".+?(?=/)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regex go brr
tonyelhabr
reviewed
Jul 8, 2022
@@ -0,0 +1,346 @@ | |||
#' @importFrom stringr str_extract | |||
generate_s3_key_bucket_ext <- function(artifact_name, run_id = get_active_run_id(), client = mlflow_client()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does _ext
signify extension? maybe _info
is better given the list that's returned
tonyelhabr
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws.s3
in favor ofpaws.storage
@tonyelhabr now if you hypothetically had a 10GB CSV file in S3 with CF scores, you can slice and dice it. Unfortunately, I don't think S3 Select let's you
group by
so I think you'd need to load the data into memory regardless :/Given the inability to group by and stuff, I may not merge this in. But leaving it here at least to come back to later in case the
paws
migration seems like a particularly great idea one day.