Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPIK-759] implement side dialog component and log a trace dialog #1111

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

awkoy
Copy link
Contributor

@awkoy awkoy commented Jan 22, 2025

Details

  • implement side dialog component and log a trace dialog
    image

Issues

Resolves #

Testing

Documentation

@awkoy awkoy requested a review from a team as a code owner January 22, 2025 12:57
Copy link
Contributor

@aadereiko aadereiko Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a similar component ResizableSidePanel. This and existing ones are used for different purposes, so you can either:

  • align their designs - f.e. how dark the shadow is
  • re-use the one that we already have

@aadereiko aadereiko self-requested a review January 23, 2025 11:57
Copy link
Contributor

@aadereiko aadereiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@awkoy awkoy merged commit fb89646 into main Jan 23, 2025
1 check passed
@awkoy awkoy deleted the awkoy/OPIK-759-side-popup-and-log-trace branch January 23, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants