remove dbs no one uses

[faddat]

• add pebbledb
• use latest pebble
• added a ton of test rigor and fixed linting
• if always false we don't need the param
• really we don't need that
• remove databases no one uses

[codecov]

Codecov Report

Attention: 107 lines in your changes are missing coverage. Please review.

Comparison is base (d03785d) 68.59% compared to head (a574117) 60.70%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
- Coverage   68.59%   60.70%   -7.89%     
==========================================
  Files          27       18       -9     
  Lines        2124     1438     -686     
==========================================
- Hits         1457      873     -584     
+ Misses        592      506      -86     
+ Partials       75       59      -16     

Files	Coverage Δ
goleveldb.go	59.84% <100.00%> (ø)
test_helpers.go	100.00% <100.00%> (ø)
util.go	36.66% <100.00%> (ø)
db.go	35.00% <50.00%> (ø)
remotedb/iterator.go	30.00% <0.00%> (ø)
remotedb/remotedb.go	39.39% <0.00%> (ø)
remotedb/batch.go	58.00% <25.00%> (-3.71%)	⬇️
remotedb/grpcdb/server.go	0.00% <0.00%> (ø)
memdb_iterator.go	90.42% <33.33%> (-2.99%)	⬇️
memdb.go	69.64% <16.66%> (-1.27%)	⬇️
... and 1 more

Files	Coverage Δ
goleveldb.go	59.84% <100.00%> (ø)
test_helpers.go	100.00% <100.00%> (ø)
util.go	36.66% <100.00%> (ø)
db.go	35.00% <50.00%> (ø)
remotedb/iterator.go	30.00% <0.00%> (ø)
remotedb/remotedb.go	39.39% <0.00%> (ø)
remotedb/batch.go	58.00% <25.00%> (-3.71%)	⬇️
remotedb/grpcdb/server.go	0.00% <0.00%> (ø)
memdb_iterator.go	90.42% <33.33%> (-2.99%)	⬇️
memdb.go	69.64% <16.66%> (-1.27%)	⬇️
... and 1 more

[faddat]

I am okay with codecov propblems. We should rip it out anyhow.

[jmalicevic]

Hi @faddat , thank you for the benchmarks and insights. As @adizere stated, we don't want to abruptly remove support for all other databases as we have a very large userbase still using them. We have plans to converge to one DB backend in the future but this requires an extensive study on what users are using. I would therefore separate the concerns of adding Pebble and removing other backends and keep in the PR only the addition of Pebble.

[faddat]

ok, I will change this to draft in that case.

[faddat]

Just so you know, somebody has written a universal converter. I just don't know who. It may have been The team that starts on a p but isn't persistence but I always forget their name

[faddat]

personally I dont care about tenths of a percent of on codecov. Please let me know if it matters.

[faddat]

I think that this PR remains a good idea.

[adizere]

The PR would be a lot better without this commit a574117. It's difficult to review right now. Can you revert that commit?

[faddat]

100%

[faddat]

closing in favor of #115