-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove Dockerfile, use only pure go dabase backends #135
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
+ Coverage 76.80% 77.26% +0.45%
==========================================
Files 23 14 -9
Lines 2048 1060 -988
==========================================
- Hits 1573 819 -754
+ Misses 403 193 -210
+ Partials 72 48 -24
... and 11 files with indirect coverage changes
|
@melekes -- this is my new proposed PR. It is simpler, easier to maintain, and faster all around. It will also reduce dramatically the amount of work needed to maintain both this repository and cometbft. The correct answer to your question about the Dockerfile, is that there's been no reason to have a Dockerfile in this repository for years. |
When this PR started, tests took more than ten minutes. They now take less than one minute. |
I think I just fixed that annoying codeql thing. |
badger is very much maintained https://github.com/dgraph-io/badger |
Co-authored-by: Anton Kaliaev <[email protected]>
@melekes it is pure go, too, so would you like to keep it? |
Co-authored-by: Anton Kaliaev <[email protected]>
…/cometbft-db into faddat/bump-go-and-pebble
I think this is ready to rock now, but there is a valid question of weather or not to include badger. Badger v4 worked out of the box. No valid reason not to include it. |
If we are going to merge this, we should. Blocks upgrading comet to go 1.22 |
I would prefer to sunset database backends iteratively:
I would also keep rocksdb around, since some users (at least Cronos, potentially others) clearly make use of it. Therefore, we should separate this PR into multiple smaller PRs:
@faddat do you plan on helping with any of the above? if so, please open corresponding PRs. if not, we plan to work on it this week so we'll go ahead within a couple of days |
it is necessary to update the dockerfile in order to update grocksdb. So ci will take a very long time now. As for phases, that's fine. We will not be able to improve docker without removing rocksdb (and other databases that use cgo) |
This PR: