Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance pebble #141

Closed
wants to merge 35 commits into from
Closed

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Mar 18, 2024

  • bump golang and pebble
  • update Dockerfile
  • use go 1.22 for govulncheck
  • bump go
  • use Dockerfile for the linter same as we do for tests
  • remove unused databses.
  • both cometbft-db and cometbft no longer need convoluted docker setups
  • remove the build tags from pebble
  • no longer need to run the linter in Docker
  • change the "ci" action
  • lint
  • add tests for pebble
  • lint
  • remove docker.yml from github actions
  • enhance pebble tests
  • make the pebble iterator tests match the goleveldb iterator tests
  • run govulncheck all the time, fix yaml lint issues in stale.yml
  • give pebble stats
  • tweak goleveldb
  • don't make .db a constant
  • Update README.md
  • change module path so celestia can use this
  • Revert "change module path so celestia can use this"
  • Update go.mod
  • Update pebble.go
  • Update Makefile
  • remove master branch from linter runs
  • use mains pebble.go
  • pebble enhancements

faddat and others added 30 commits February 15, 2024 15:34
Co-authored-by: Anton Kaliaev <[email protected]>
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 54.05405% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 74.94%. Comparing base (fb4f703) to head (d597789).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   76.80%   74.94%   -1.87%     
==========================================
  Files          23       13      -10     
  Lines        2048      930    -1118     
==========================================
- Hits         1573      697     -876     
+ Misses        403      190     -213     
+ Partials       72       43      -29     
Files Coverage Δ
goleveldb.go 65.51% <100.00%> (+5.67%) ⬆️
pebble.go 70.71% <37.03%> (-2.86%) ⬇️

... and 10 files with indirect coverage changes

Files Coverage Δ
goleveldb.go 65.51% <100.00%> (+5.67%) ⬆️
pebble.go 70.71% <37.03%> (-2.86%) ⬇️

... and 10 files with indirect coverage changes

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added Stale and removed Stale labels Mar 29, 2024
@melekes
Copy link
Contributor

melekes commented Apr 7, 2024

I'm sorry @faddat. This PR is too big and needs to be broken down into smaller parts.

@melekes melekes closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants