Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix arm64 build #240

Merged
merged 20 commits into from
Feb 12, 2025
Merged

ci: fix arm64 build #240

merged 20 commits into from
Feb 12, 2025

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Feb 10, 2025 •
edited
Loading

Closes #234

Removes govulncheck CI job - mirrors cometbft/cometbft#4946

@melekes melekes marked this pull request as ready for review February 10, 2025 15:20
@melekes melekes requested review from a team as code owners February 10, 2025 15:20
@melekes melekes requested a review from zrbecker February 10, 2025 15:20
@melekes melekes self-assigned this Feb 10, 2025
melekes
melekes commented Feb 10, 2025
View reviewed changes
@melekes
Copy link
Contributor Author

melekes commented Feb 10, 2025

This needs to be backported to https://github.com/cometbft/cometbft-db/tree/v0.14.x

zrbecker
zrbecker requested changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@zrbecker zrbecker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like test builds this successfully in CI which is great.

Just put a few comments on here.

zrbecker
zrbecker reviewed Feb 11, 2025
View reviewed changes
@melekes
Copy link
Contributor Author

melekes commented Feb 12, 2025

@zrbecker please rename test-fast to test in GH repo settings (list of required CI jobs).

@zrbecker

This comment was marked as resolved.

Sign in to view
@zrbecker

This comment was marked as outdated.

Sign in to view
@melekes

This comment was marked as outdated.

Sign in to view
@zrbecker

This comment was marked as outdated.

Sign in to view
@melekes melekes requested a review from zrbecker February 12, 2025 09:41
@melekes melekes enabled auto-merge February 12, 2025 10:03
@melekes melekes added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit ca3ad46 Feb 12, 2025
8 checks passed
@melekes melekes deleted the 234-fix-arm64-build-2 branch February 12, 2025 10:25
melekes added a commit that referenced this pull request Feb 12, 2025
@melekes
ci: fix arm64 build (#240)
8970751 
Closes #234
@melekes melekes mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zrbecker zrbecker zrbecker approved these changes

Assignees

@melekes melekes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix arm64 build
2 participants
@melekes @zrbecker