Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move input/output annotation from manager to separate method #3804

Merged

Conversation

amickan
Copy link
Contributor

@amickan amickan commented Jan 29, 2025

I added an input/output count annotation to the AlgorithmInterfaceManager in my last PR, but had not tested the migrations again. In my migration check for the phase interfaces, I realized that the migrations break with that addition since they don't have access to custom manager methods. So I'm moving the annotation to a separate function here. The upside of this is that I can now use it in 2 other places where we're making the same annotation. So I'm calling this a win.

Note that this does not add or change functionality, it just moves the code. So I didn't spend time on adding a test for the new function - it is indirectly covered by tests of all the places where it is used.

Copy link
Member

@jmsmkn jmsmkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a small question.

app/grandchallenge/algorithms/forms.py Show resolved Hide resolved
@amickan amickan merged commit 9a1bd62 into feat_optional_inputs Jan 30, 2025
8 checks passed
@amickan amickan deleted the move_manager_annotation_to_seperate_method branch January 30, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants