Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flasher re-downloads and unpacks same images #84

Open
incognitojam opened this issue Jan 24, 2025 · 1 comment
Open

Flasher re-downloads and unpacks same images #84

incognitojam opened this issue Jan 24, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@incognitojam
Copy link
Member

incognitojam commented Jan 24, 2025

After flashing a device I refreshed the page to test again and it re-downloaded and started unpacking the images again. The storage quota used was increasing in devtools.

Need to make sure:

  • if the image checksum fails, to delete the image/archive
  • delete old images?
@incognitojam incognitojam added the bug Something isn't working label Jan 24, 2025
@adeebshihadeh
Copy link
Collaborator

I think we delete the old images. We need to keep the memory usage super minimal, and I think we'll never even see the full image -- just stream the chunks directly to the device as they come in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants